-
Notifications
You must be signed in to change notification settings - Fork 1
Contribution guidelines #2
base: master
Are you sure you want to change the base?
Conversation
contribution_guidelines.md
Outdated
| - For larger API change request, it's recommended to open an issue, where you can get quicker feedback on your idea instead of having to wait until it has been implemented or your PR gets approved. | ||
|
|
||
| ## Code of conduct | ||
| This project adheres to the [Open Code of Conduct](https://github.com/todogroup/opencodeofconduct). By participating, you are expected to honor this code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could write our own CoC. Looks like the OCoC is discontinued.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, sounds good. Will do that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peredaniel @LeeMatthewHiggins I've added my 5 cents to the Code of Conduct but any contribution is welcome. Could you please give it a peek? Thanks
README.md
Outdated
|
|
||
| ## Contribute | ||
|
|
||
| In order to contribute to the ContainerCollection framework, first read our [Contribution guidelines](contribution_guidelines.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is missing a dot "." at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
|
Can't merge without other approval @peredaniel |
Add contribution guidelines.