fix: more robust discord handling #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR improves the robustness of Discord guild member role fetching by enhancing error handling and API interaction patterns. The changes address issue #1179 by making the code more resilient to common Discord API scenarios.
- Improved guild fetching to support both cached and non-cached guilds via fallback to
fetch() - Added specific handling for Discord error code 10007 (Unknown Member) with appropriate debug logging
- Enhanced JSDoc documentation with complete type information including return types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
That will be hard to confirm. I guess I could confirm after few weeks or so |
Collaborator
Author
|
Okay so I'll merge for now. Please report back if things break. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
# [1.41.0-develop.3](v1.41.0-develop.2...v1.41.0-develop.3) (2025-12-16) ### Bug Fixes * logic bug in loading non-clustered elements ([#1161](#1161)) ([a2c7f17](a2c7f17)) * more robust discord handling ([#1181](#1181)) ([b579ded](b579ded)) ### Features * default clientPrompt to none to skip permission reapproval ([d3ea283](d3ea283))
|
🎉 This PR is included in version 1.41.0-develop.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1179? @kamieniarz