Migrate "old" conditions #6330
Merged
Migrate "old" conditions #6330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyperghost
force-pushed
the
6.3-condition-migrate
branch
from
9565c65 to
f2e7e53
Compare
dtdesign
requested changes
Jun 25, 2025
wcfsetup/install/files/acp/database/update_com.woltlab.wcf_6.3_step1.php
Outdated
Show resolved
Hide resolved
...files/lib/system/user/group/assignment/command/UserGroupAssignmentMigrateCondition.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/cache/eager/UserGroupAssignmentCache.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/condition/ConditionHandler.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/condition/type/user/AbstractUserStringConditionType.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/condition/type/user/AbstractUserStringConditionType.class.php
Outdated
Show resolved
Hide resolved
...tup/install/files/lib/system/condition/type/user/UserRegistrationDateConditionType.class.php
Outdated
Show resolved
Hide resolved
...tup/install/files/lib/system/condition/type/user/UserRegistrationDaysConditionType.class.php
Outdated
Show resolved
Hide resolved
...files/lib/system/user/group/assignment/command/UserGroupAssignmentMigrateCondition.class.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
…condition-migrate
dtdesign
requested changes
Jul 4, 2025
Member
dtdesign
left a comment
dtdesign
left a comment
There was a problem hiding this comment.
Please also add an ACP status box of type warning to notify about outstanding migrations.
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
dtdesign
requested changes
Jul 9, 2025
wcfsetup/install/files/lib/system/acp/dashboard/box/StatusMessageAcpDashboardBox.class.php
Outdated
Show resolved
Hide resolved
If we're going to instantiate them via anonymous classes, we can just drop the `abstract` because their entire implementation is non-abstract anyway.
There is very little gain in offering `addConditions()` plus it requires us to validate an arbitrary array in contrast to relying on `addCondition()` with its type hin.
Avoiding the repetition makes it easier to find conditions.
Add phpstan docs
The content of `wcf.condition.add` has been swapped between German and English.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #6304
See #6310
TODO
6.3-condition