Skip to content

Remove the tracking of user profile hits #6449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtdesign merged 1 commit into from
Sep 1, 2025
Merged

Remove the tracking of user profile hits #6449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions wcfsetup/install/files/acp/database/update_com.woltlab.wcf_6.2_step1.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
IntDatabaseTableColumn::create('coverPhotoFileID')
->length(10)
->defaultValue(null),
IntDatabaseTableColumn::create('profileHits')
->drop(),
])
->foreignKeys([
DatabaseTableForeignKey::create()
Expand Down
1 change: 0 additions & 1 deletion wcfsetup/install/files/acp/templates/userSearch.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@
{/if}
<label><input type="checkbox" name="columns[]" value="registrationDate"{if "registrationDate"|in_array:$columns} checked{/if}> {lang}wcf.user.registrationDate{/lang}</label>
<label><input type="checkbox" name="columns[]" value="lastActivityTime"{if "lastActivityTime"|in_array:$columns} checked{/if}> {lang}wcf.user.lastActivityTime{/lang}</label>
<label><input type="checkbox" name="columns[]" value="profileHits"{if "profileHits"|in_array:$columns} checked{/if}> {lang}wcf.user.profileHits{/lang}</label>
<label><input type="checkbox" name="columns[]" value="activityPoints"{if "activityPoints"|in_array:$columns} checked{/if}> {lang}wcf.user.activityPoint{/lang}</label>
{if MODULE_LIKE}
<label><input type="checkbox" name="columns[]" value="likesReceived"{if "likesReceived"|in_array:$columns} checked{/if}> {lang}wcf.like.likesReceived{/lang}</label>
Expand Down
3 changes: 0 additions & 3 deletions wcfsetup/install/files/lib/acp/page/UserListPage.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ class UserListPage extends SortablePage
public $columnStyling = [
'registrationDate' => 'columnDate',
'lastActivityTime' => 'columnDate',
'profileHits' => 'columnDigits',
'activityPoints' => 'columnDigits',
'likesReceived' => 'columnDigits',
];
Expand Down Expand Up @@ -134,7 +133,6 @@ class UserListPage extends SortablePage
'registrationDate',
'username',
'lastActivityTime',
'profileHits',
'activityPoints',
'likesReceived',
];
Expand Down Expand Up @@ -343,7 +341,6 @@ protected function readUsers()
);
break;

case 'profileHits':
case 'activityPoints':
case 'likesReceived':
$this->columnValues[$user->userID][$column] = StringUtil::formatNumeric($user->{$column});
Expand Down
1 change: 0 additions & 1 deletion wcfsetup/install/files/lib/data/user/User.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
* @property-read string $disableSignatureReason reason why the user's signature is disabled
* @property-read int $disableSignatureExpires timestamp at which the user's signature will automatically be enabled again
* @property-read int $lastActivityTime timestamp of the user's last activity
* @property-read int $profileHits number of times the user's profile has been visited
* @property-read int|null $rankID id of the user's rank or null if they have no rank
* @property-read string $userTitle custom user title used instead of rank title or empty if user has no custom title
* @property-read int|null $userOnlineGroupID id of the user group whose online marking is used when printing the user's formatted name or null if no special marking is used
Expand Down
5 changes: 0 additions & 5 deletions wcfsetup/install/files/lib/page/UserPage.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,6 @@ public function show()
{
// update profile hits
if ($this->user->userID != WCF::getUser()->userID && !WCF::getSession()->spiderIdentifier && !$this->user->isProtected()) {
$editor = new UserEditor($this->user->getDecoratedObject());
$editor->updateCounters(['profileHits' => 1]);

// save visitor
/** @noinspection PhpUndefinedFieldInspection */
if (PROFILE_ENABLE_VISITORS && WCF::getUser()->userID && !WCF::getUser()->canViewOnlineStatus) {
(new UserProfileVisitorAction([], 'registerVisitor', [
'data' => [
Expand Down
4 changes: 2 additions & 2 deletions wcfsetup/install/lang/de.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4706,8 +4706,6 @@ Erlaubte Dateiendungen: gif, jpg, jpeg, png, webp]]></item>
<item name="wcf.user.membersList.location"><![CDATA[aus {$user->location}]]></item>
<item name="wcf.user.myProfile"><![CDATA[Mein Profil]]></item>
<item name="wcf.user.editProfile"><![CDATA[Profil bearbeiten]]></item>
<item name="wcf.user.profileHits"><![CDATA[Profil-Aufrufe]]></item>
<item name="wcf.user.profileHits.hitsPerDay"><![CDATA[{#$user->profileHits/$user->getProfileAge()} Aufrufe pro Tag]]></item>
<item name="wcf.user.online"><![CDATA[Online]]></item>
<item name="wcf.user.online.title"><![CDATA[{$username} ist online]]></item>
<item name="wcf.user.button.follow"><![CDATA[Folgen]]></item>
Expand Down Expand Up @@ -7654,5 +7652,7 @@ Erlaubte Dateiendungen: {', '|implode:$allowedFileExtensions}]]></item>
<item name="wcf.clipboard.label.com.woltlab.wcf.moderation.queue.marked"/>
<item name="wcf.acp.label.sortAfterGroupFiltering"/>
<item name="wcf.acp.menu.link.contact.settings"/>
<item name="wcf.user.profileHits"/>
<item name="wcf.user.profileHits.hitsPerDay"/>
</delete>
</language>
4 changes: 2 additions & 2 deletions wcfsetup/install/lang/en.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4711,8 +4711,6 @@ Allowed extensions: gif, jpg, jpeg, png, webp]]></item>
<item name="wcf.user.membersList.location"><![CDATA[from {$user->location}]]></item>
<item name="wcf.user.myProfile"><![CDATA[My Profile]]></item>
<item name="wcf.user.editProfile"><![CDATA[Edit Profile]]></item>
<item name="wcf.user.profileHits"><![CDATA[Profile Hits]]></item>
<item name="wcf.user.profileHits.hitsPerDay"><![CDATA[{#$user->profileHits/$user->getProfileAge()} hits per day]]></item>
<item name="wcf.user.online"><![CDATA[Online]]></item>
<item name="wcf.user.online.title"><![CDATA[{$username} is online]]></item>
<item name="wcf.user.button.follow"><![CDATA[Follow]]></item>
Expand Down Expand Up @@ -7545,5 +7543,7 @@ Allowed extensions: {', '|implode:$allowedFileExtensions}]]></item>
<item name="wcf.clipboard.label.com.woltlab.wcf.moderation.queue.marked"/>
<item name="wcf.acp.label.sortAfterGroupFiltering"/>
<item name="wcf.acp.menu.link.contact.settings"/>
<item name="wcf.user.profileHits"/>
<item name="wcf.user.profileHits.hitsPerDay"/>
</delete>
</language>
1 change: 0 additions & 1 deletion wcfsetup/setup/db/install.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1570,7 +1570,6 @@ CREATE TABLE wcf1_user (
disableSignatureReason TEXT,
disableSignatureExpires INT(10) NOT NULL DEFAULT 0,
lastActivityTime INT(10) NOT NULL DEFAULT 0,
profileHits INT(10) NOT NULL DEFAULT 0,
rankID INT(10),
userTitle VARCHAR(255) NOT NULL DEFAULT '',
userOnlineGroupID INT(10),
Expand Down