Skip to content

Adjust db column types created by form options #6523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BurntimeX merged 1 commit into from
Nov 20, 2025
Merged

Adjust db column types created by form options #6523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions wcfsetup/install/files/lib/system/form/option/EmailFormOption.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
namespace wcf\system\form\option;

use wcf\data\DatabaseObjectList;
use wcf\system\database\table\column\AbstractDatabaseTableColumn;
use wcf\system\database\table\column\VarcharDatabaseTableColumn;
use wcf\system\form\builder\field\AbstractFormField;
use wcf\system\form\builder\field\EmailFormField;
use wcf\system\form\builder\field\TextFormField;
Expand Down Expand Up @@ -55,4 +57,11 @@ public function applyFilter(DatabaseObjectList $list, string $columnName, mixed
{
$list->getConditionBuilder()->add("{$columnName} LIKE ?", ['%' . WCF::getDB()->escapeLikeValue($value) . '%']);
}

#[\Override]
public function getDatabaseTableColumn(string $name): AbstractDatabaseTableColumn
{
return VarcharDatabaseTableColumn::create($name)
->length(255);
}
}
9 changes: 9 additions & 0 deletions wcfsetup/install/files/lib/system/form/option/IconFormOption.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

namespace wcf\system\form\option;

use wcf\system\database\table\column\AbstractDatabaseTableColumn;
use wcf\system\database\table\column\VarcharDatabaseTableColumn;
use wcf\system\form\builder\field\AbstractFormField;
use wcf\system\form\builder\field\IconFormField;
use wcf\system\form\option\formatter\IconFormatter;
Expand Down Expand Up @@ -46,4 +48,11 @@ public function isFilterable(): bool
{
return false;
}

#[\Override]
public function getDatabaseTableColumn(string $name): AbstractDatabaseTableColumn
{
return VarcharDatabaseTableColumn::create($name)
->length(255);
}
}
8 changes: 8 additions & 0 deletions wcfsetup/install/files/lib/system/form/option/RatingFormOption.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

namespace wcf\system\form\option;

use wcf\system\database\table\column\AbstractDatabaseTableColumn;
use wcf\system\database\table\column\TinyintDatabaseTableColumn;
use wcf\system\form\builder\field\AbstractFormField;
use wcf\system\form\builder\field\RatingFormField;
use wcf\system\form\option\formatter\IFormOptionFormatter;
Expand Down Expand Up @@ -42,4 +44,10 @@ public function getFormatter(): IFormOptionFormatter
{
return new RatingFormatter();
}

#[\Override]
public function getDatabaseTableColumn(string $name): AbstractDatabaseTableColumn
{
return TinyintDatabaseTableColumn::create($name);
}
}
9 changes: 9 additions & 0 deletions wcfsetup/install/files/lib/system/form/option/SelectFormOption.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

namespace wcf\system\form\option;

use wcf\system\database\table\column\AbstractDatabaseTableColumn;
use wcf\system\database\table\column\VarcharDatabaseTableColumn;
use wcf\system\form\builder\field\AbstractFormField;
use wcf\system\form\builder\field\SelectFormField;
use wcf\system\form\option\formatter\IFormOptionFormatter;
Expand Down Expand Up @@ -51,4 +53,11 @@ public function getPlainTextFormatter(): IFormOptionFormatter
{
return new SelectFormatter(false);
}

#[\Override]
public function getDatabaseTableColumn(string $name): AbstractDatabaseTableColumn
{
return VarcharDatabaseTableColumn::create($name)
->length(255);
}
}
19 changes: 16 additions & 3 deletions wcfsetup/install/files/lib/system/form/option/TextFormOption.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
namespace wcf\system\form\option;

use wcf\data\DatabaseObjectList;
use wcf\system\database\table\column\AbstractDatabaseTableColumn;
use wcf\system\database\table\column\VarcharDatabaseTableColumn;
use wcf\system\form\builder\field\AbstractFormField;
use wcf\system\form\builder\field\TextFormField;
use wcf\system\WCF;
Expand Down Expand Up @@ -33,9 +35,13 @@ public function getFilterFormField(string $id, array $configuration = []): Abstr
public function getFormField(string $id, array $configuration = []): AbstractFormField
{
$formField = TextFormField::create($id);
if (!empty($configuration['maxLength'])) {
$formField->maximumLength($configuration['maxLength']);
}
$formField->maximumLength(
\min(
255,
$configuration['maxLength'] ?? 255
)
);

if (isset($configuration['defaultTextValue'])) {
$formField->value($configuration['defaultTextValue']);
}
Expand All @@ -54,4 +60,11 @@ public function applyFilter(DatabaseObjectList $list, string $columnName, mixed
{
$list->getConditionBuilder()->add("{$columnName} LIKE ?", ['%' . WCF::getDB()->escapeLikeValue($value) . '%']);
}

#[\Override]
public function getDatabaseTableColumn(string $name): AbstractDatabaseTableColumn
{
return VarcharDatabaseTableColumn::create($name)
->length(255);
}
}
8 changes: 8 additions & 0 deletions wcfsetup/install/files/lib/system/form/option/UrlFormOption.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
namespace wcf\system\form\option;

use wcf\data\DatabaseObjectList;
use wcf\system\database\table\column\AbstractDatabaseTableColumn;
use wcf\system\database\table\column\TextDatabaseTableColumn;
use wcf\system\form\builder\field\AbstractFormField;
use wcf\system\form\builder\field\TextFormField;
use wcf\system\form\builder\field\UrlFormField;
Expand Down Expand Up @@ -49,4 +51,10 @@ public function applyFilter(DatabaseObjectList $list, string $columnName, mixed
{
$list->getConditionBuilder()->add("{$columnName} LIKE ?", ['%' . WCF::getDB()->escapeLikeValue($value) . '%']);
}

#[\Override]
public function getDatabaseTableColumn(string $name): AbstractDatabaseTableColumn
{
return TextDatabaseTableColumn::create($name);
}
}