-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Handle multiple feeds in fetch_feed().
#10631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Handle multiple feeds in fetch_feed().
#10631
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
b73e186 to
3ec52a0
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
3ec52a0 to
1e227d2
Compare
| $items = SimplePie\SimplePie::merge_items( $feeds ); | ||
| $feed->init(); | ||
| $feed->data['items'] = $items; | ||
| return $feed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we perform an early return, the wp_feed_options hook won't fire. This may require a slightly more complicated fix to handle everything properly...
Handles passing an array to
fetch_feed()by requesting each feed individually and then callingSimplePie\SimplePie::merge_items();on the result before passing the data back in to a SimplePie object.I don't love this so would love some suggestions of anything I am missing.
Trac ticket: https://core.trac.wordpress.org/ticket/64136
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.