Skip to content

Use null coalescing operator (??) for remaining uses of isset() #10654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
westonruter wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Use null coalescing operator (??) for remaining uses of isset() #10654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wp-admin/edit-comments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@
}

if ( $spammed > 0 ) {
$ids = isset( $_REQUEST['ids'] ) ? $_REQUEST['ids'] : 0;
$ids = $_REQUEST['ids'] ?? 0;

$messages[] = sprintf(
/* translators: %s: Number of comments. */
Expand All @@ -359,7 +359,7 @@
}

if ( $trashed > 0 ) {
$ids = isset( $_REQUEST['ids'] ) ? $_REQUEST['ids'] : 0;
$ids = $_REQUEST['ids'] ?? 0;

$messages[] = sprintf(
/* translators: %s: Number of comments. */
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/edit-form-advanced.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
*/
$post_ID = isset( $post_ID ) ? (int) $post_ID : 0;
$user_ID = isset( $user_ID ) ? (int) $user_ID : 0;
$action = isset( $action ) ? $action : '';
$action = $action ?? '';

if ( (int) get_option( 'page_for_posts' ) === $post->ID && empty( $post->post_content ) ) {
add_action( 'edit_form_after_title', '_wp_posts_page_notice' );
Expand Down
10 changes: 5 additions & 5 deletions src/wp-admin/includes/ajax-actions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1808,7 +1808,7 @@ function wp_ajax_closed_postboxes() {
$hidden = isset( $_POST['hidden'] ) ? explode( ',', $_POST['hidden'] ) : array();
$hidden = array_filter( $hidden );

$page = isset( $_POST['page'] ) ? $_POST['page'] : '';
$page = $_POST['page'] ?? '';

if ( sanitize_key( $page ) !== $page ) {
wp_die( 0 );
Expand Down Expand Up @@ -1839,7 +1839,7 @@ function wp_ajax_closed_postboxes() {
*/
function wp_ajax_hidden_columns() {
check_ajax_referer( 'screen-options-nonce', 'screenoptionnonce' );
$page = isset( $_POST['page'] ) ? $_POST['page'] : '';
$page = $_POST['page'] ?? '';

if ( sanitize_key( $page ) !== $page ) {
wp_die( 0 );
Expand Down Expand Up @@ -1988,13 +1988,13 @@ function wp_ajax_menu_locations_save() {
function wp_ajax_meta_box_order() {
check_ajax_referer( 'meta-box-order' );
$order = isset( $_POST['order'] ) ? (array) $_POST['order'] : false;
$page_columns = isset( $_POST['page_columns'] ) ? $_POST['page_columns'] : 'auto';
$page_columns = $_POST['page_columns'] ?? 'auto';

if ( 'auto' !== $page_columns ) {
$page_columns = (int) $page_columns;
}

$page = isset( $_POST['page'] ) ? $_POST['page'] : '';
$page = $_POST['page'] ?? '';

if ( sanitize_key( $page ) !== $page ) {
wp_die( 0 );
Expand Down Expand Up @@ -2052,7 +2052,7 @@ function wp_ajax_get_permalink() {
function wp_ajax_sample_permalink() {
check_ajax_referer( 'samplepermalink', 'samplepermalinknonce' );
$post_id = isset( $_POST['post_id'] ) ? (int) $_POST['post_id'] : 0;
$title = isset( $_POST['new_title'] ) ? $_POST['new_title'] : '';
$title = $_POST['new_title'] ?? '';
$slug = isset( $_POST['new_slug'] ) ? $_POST['new_slug'] : null;
wp_die( get_sample_permalink_html( $post_id, $title, $slug ) );
}
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/class-core-upgrader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ public static function should_update_to_version( $offered_ver ) {
public function check_files() {
global $wp_version, $wp_local_package;

$checksums = get_core_checksums( $wp_version, isset( $wp_local_package ) ? $wp_local_package : 'en_US' );
$checksums = get_core_checksums( $wp_version, $wp_local_package ?? 'en_US' );

if ( ! is_array( $checksums ) ) {
return false;
Expand Down
6 changes: 3 additions & 3 deletions src/wp-admin/includes/class-custom-image-header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,7 +1351,7 @@ final public function create_attachment_object( $cropped, $parent_attachment_id
* @return int Attachment ID.
*/
final public function insert_attachment( $attachment, $cropped ) {
$parent_id = isset( $attachment['post_parent'] ) ? $attachment['post_parent'] : null;
$parent_id = $attachment['post_parent'] ?? null;
unset( $attachment['post_parent'] );

$attachment_id = wp_insert_attachment( $attachment, $cropped );
Expand Down Expand Up @@ -1584,8 +1584,8 @@ public function get_uploaded_header_images() {

foreach ( $header_images as &$header_image ) {
$header_meta = get_post_meta( $header_image['attachment_id'] );
$header_image['timestamp'] = isset( $header_meta[ $timestamp_key ] ) ? $header_meta[ $timestamp_key ] : '';
$header_image['alt_text'] = isset( $header_meta[ $alt_text_key ] ) ? $header_meta[ $alt_text_key ] : '';
$header_image['timestamp'] = $header_meta[ $timestamp_key ] ?? '';
$header_image['alt_text'] = $header_meta[ $alt_text_key ] ?? '';
}

return $header_images;
Expand Down
6 changes: 3 additions & 3 deletions src/wp-admin/includes/class-plugin-installer-skin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function __construct( $args = array() ) {

$this->type = $args['type'];
$this->url = $args['url'];
$this->api = isset( $args['api'] ) ? $args['api'] : array();
$this->api = $args['api'] ?? array();
$this->overwrite = $args['overwrite'];

parent::__construct( $args );
Expand Down Expand Up @@ -265,8 +265,8 @@ private function do_overwrite() {
$blocked_message = '<p>' . esc_html__( 'The plugin cannot be updated due to the following:' ) . '</p>';
$blocked_message .= '<ul class="ul-disc">';

$requires_php = isset( $new_plugin_data['RequiresPHP'] ) ? $new_plugin_data['RequiresPHP'] : null;
$requires_wp = isset( $new_plugin_data['RequiresWP'] ) ? $new_plugin_data['RequiresWP'] : null;
$requires_php = $new_plugin_data['RequiresPHP'] ?? null;
$requires_wp = $new_plugin_data['RequiresWP'] ?? null;

if ( ! is_php_version_compatible( $requires_php ) ) {
$error = sprintf(
Expand Down
12 changes: 6 additions & 6 deletions src/wp-admin/includes/class-plugin-upgrader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,8 +490,8 @@ public function check_package( $source ) {
return new WP_Error( 'incompatible_archive_no_plugins', $this->strings['incompatible_archive'], __( 'No valid plugins were found.' ) );
}

$requires_php = isset( $new_plugin_data['RequiresPHP'] ) ? $new_plugin_data['RequiresPHP'] : null;
$requires_wp = isset( $new_plugin_data['RequiresWP'] ) ? $new_plugin_data['RequiresWP'] : null;
$requires_php = $new_plugin_data['RequiresPHP'] ?? null;
$requires_wp = $new_plugin_data['RequiresWP'] ?? null;

if ( ! is_php_version_compatible( $requires_php ) ) {
$error = sprintf(
Expand Down Expand Up @@ -570,7 +570,7 @@ public function deactivate_plugin_before_upgrade( $response, $plugin ) {
return $response;
}

$plugin = isset( $plugin['plugin'] ) ? $plugin['plugin'] : '';
$plugin = $plugin['plugin'] ?? '';
if ( empty( $plugin ) ) {
return new WP_Error( 'bad_request', $this->strings['bad_request'] );
}
Expand Down Expand Up @@ -604,7 +604,7 @@ public function active_before( $response, $plugin ) {
return $response;
}

$plugin = isset( $plugin['plugin'] ) ? $plugin['plugin'] : '';
$plugin = $plugin['plugin'] ?? '';

// Only run if plugin is active.
if ( ! is_plugin_active( $plugin ) ) {
Expand Down Expand Up @@ -640,7 +640,7 @@ public function active_after( $response, $plugin ) {
return $response;
}

$plugin = isset( $plugin['plugin'] ) ? $plugin['plugin'] : '';
$plugin = $plugin['plugin'] ?? '';

// Only run if plugin is active.
if ( ! is_plugin_active( $plugin ) ) {
Expand Down Expand Up @@ -679,7 +679,7 @@ public function delete_old_plugin( $removed, $local_destination, $remote_destina
return $removed; // Pass errors through.
}

$plugin = isset( $plugin['plugin'] ) ? $plugin['plugin'] : '';
$plugin = $plugin['plugin'] ?? '';
if ( empty( $plugin ) ) {
return new WP_Error( 'bad_request', $this->strings['bad_request'] );
}
Expand Down
6 changes: 3 additions & 3 deletions src/wp-admin/includes/class-theme-installer-skin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function __construct( $args = array() ) {

$this->type = $args['type'];
$this->url = $args['url'];
$this->api = isset( $args['api'] ) ? $args['api'] : array();
$this->api = $args['api'] ?? array();
$this->overwrite = $args['overwrite'];

parent::__construct( $args );
Expand Down Expand Up @@ -310,8 +310,8 @@ private function do_overwrite() {
$blocked_message = '<p>' . esc_html__( 'The theme cannot be updated due to the following:' ) . '</p>';
$blocked_message .= '<ul class="ul-disc">';

$requires_php = isset( $new_theme_data['RequiresPHP'] ) ? $new_theme_data['RequiresPHP'] : null;
$requires_wp = isset( $new_theme_data['RequiresWP'] ) ? $new_theme_data['RequiresWP'] : null;
$requires_php = $new_theme_data['RequiresPHP'] ?? null;
$requires_wp = $new_theme_data['RequiresWP'] ?? null;

if ( ! is_php_version_compatible( $requires_php ) ) {
$error = sprintf(
Expand Down
8 changes: 4 additions & 4 deletions src/wp-admin/includes/class-theme-upgrader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,8 +639,8 @@ public function check_package( $source ) {
);
}

$requires_php = isset( $new_theme_data['RequiresPHP'] ) ? $new_theme_data['RequiresPHP'] : null;
$requires_wp = isset( $new_theme_data['RequiresWP'] ) ? $new_theme_data['RequiresWP'] : null;
$requires_php = $new_theme_data['RequiresPHP'] ?? null;
$requires_wp = $new_theme_data['RequiresWP'] ?? null;

if ( ! is_php_version_compatible( $requires_php ) ) {
$error = sprintf(
Expand Down Expand Up @@ -685,7 +685,7 @@ public function current_before( $response, $theme ) {
return $response;
}

$theme = isset( $theme['theme'] ) ? $theme['theme'] : '';
$theme = $theme['theme'] ?? '';

// Only run if active theme.
if ( get_stylesheet() !== $theme ) {
Expand Down Expand Up @@ -717,7 +717,7 @@ public function current_after( $response, $theme ) {
return $response;
}

$theme = isset( $theme['theme'] ) ? $theme['theme'] : '';
$theme = $theme['theme'] ?? '';

// Only run if active theme.
if ( get_stylesheet() !== $theme ) {
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/class-wp-community-events.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public function get_events( $location_search = '', $timezone = '' ) {
} elseif ( ! isset( $response_body['location'], $response_body['events'] ) ) {
$response_error = new WP_Error(
'api-invalid-response',
isset( $response_body['error'] ) ? $response_body['error'] : __( 'Unknown API error.' )
$response_body['error'] ?? __( 'Unknown API error.' )
);
}

Expand Down
4 changes: 2 additions & 2 deletions src/wp-admin/includes/class-wp-debug-data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,8 @@ private static function get_wp_server(): array {
);
$fields['httpd_software'] = array(
'label' => __( 'Web server' ),
'value' => ( isset( $_SERVER['SERVER_SOFTWARE'] ) ? $_SERVER['SERVER_SOFTWARE'] : __( 'Unable to determine what web server software is used' ) ),
'debug' => ( isset( $_SERVER['SERVER_SOFTWARE'] ) ? $_SERVER['SERVER_SOFTWARE'] : 'unknown' ),
'value' => ( $_SERVER['SERVER_SOFTWARE'] ?? __( 'Unable to determine what web server software is used' ) ),
'debug' => ( $_SERVER['SERVER_SOFTWARE'] ?? 'unknown' ),
);
$fields['php_version'] = array(
'label' => __( 'PHP version' ),
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/class-wp-links-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function __construct( $args = array() ) {
parent::__construct(
array(
'plural' => 'bookmarks',
'screen' => isset( $args['screen'] ) ? $args['screen'] : null,
'screen' => $args['screen'] ?? null,
)
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/class-wp-media-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function __construct( $args = array() ) {
parent::__construct(
array(
'plural' => 'media',
'screen' => isset( $args['screen'] ) ? $args['screen'] : null,
'screen' => $args['screen'] ?? null,
)
);
}
Expand Down
6 changes: 3 additions & 3 deletions src/wp-admin/includes/class-wp-ms-themes-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ public function __construct( $args = array() ) {
parent::__construct(
array(
'plural' => 'themes',
'screen' => isset( $args['screen'] ) ? $args['screen'] : null,
'screen' => $args['screen'] ?? null,
)
);

$status = isset( $_REQUEST['theme_status'] ) ? $_REQUEST['theme_status'] : 'all';
$status = $_REQUEST['theme_status'] ?? 'all';
if ( ! in_array( $status, array( 'all', 'enabled', 'disabled', 'upgrade', 'search', 'broken', 'auto-update-enabled', 'auto-update-disabled' ), true ) ) {
$status = 'all';
}
Expand Down Expand Up @@ -153,7 +153,7 @@ public function prepare_items() {
$themes[ $filter ][ $key ] = $themes['all'][ $key ];

$theme_data = array(
'update_supported' => isset( $theme->update_supported ) ? $theme->update_supported : true,
'update_supported' => $theme->update_supported ?? true,
);

// Extra info if known. array_merge() ensures $theme_data has precedence if keys collide.
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/class-wp-ms-users-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public function prepare_items() {

$users_per_page = $this->get_items_per_page( 'users_network_per_page' );

$role = isset( $_REQUEST['role'] ) ? $_REQUEST['role'] : '';
$role = $_REQUEST['role'] ?? '';

$paged = $this->get_pagenum();

Expand Down
4 changes: 2 additions & 2 deletions src/wp-admin/includes/class-wp-plugin-install-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,8 +556,8 @@ public function display_rows() {
$author = ' <cite>' . sprintf( __( 'By %s' ), $author ) . '</cite>';
}

$requires_php = isset( $plugin['requires_php'] ) ? $plugin['requires_php'] : null;
$requires_wp = isset( $plugin['requires'] ) ? $plugin['requires'] : null;
$requires_php = $plugin['requires_php'] ?? null;
$requires_wp = $plugin['requires'] ?? null;

$compatible_php = is_php_version_compatible( $requires_php );
$compatible_wp = is_wp_version_compatible( $requires_wp );
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/class-wp-terms-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public function __construct( $args = array() ) {
array(
'plural' => 'tags',
'singular' => 'tag',
'screen' => isset( $args['screen'] ) ? $args['screen'] : null,
'screen' => $args['screen'] ?? null,
)
);

Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/class-wp-themes-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public function __construct( $args = array() ) {
parent::__construct(
array(
'ajax' => true,
'screen' => isset( $args['screen'] ) ? $args['screen'] : null,
'screen' => $args['screen'] ?? null,
)
);
}
Expand Down
4 changes: 2 additions & 2 deletions src/wp-admin/includes/class-wp-users-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function __construct( $args = array() ) {
array(
'singular' => 'user',
'plural' => 'users',
'screen' => isset( $args['screen'] ) ? $args['screen'] : null,
'screen' => $args['screen'] ?? null,
)
);

Expand Down Expand Up @@ -85,7 +85,7 @@ public function prepare_items() {

$usersearch = isset( $_REQUEST['s'] ) ? wp_unslash( trim( $_REQUEST['s'] ) ) : '';

$role = isset( $_REQUEST['role'] ) ? $_REQUEST['role'] : '';
$role = $_REQUEST['role'] ?? '';

$per_page = ( $this->is_site_users ) ? 'site_users_network_per_page' : 'users_per_page';
$users_per_page = $this->get_items_per_page( $per_page );
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/credits.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ function wp_credits_section_title( $group_data = array() ) {
* @param string $slug The current group to display.
*/
function wp_credits_section_list( $credits = array(), $slug = '' ) {
$group_data = isset( $credits['groups'][ $slug ] ) ? $credits['groups'][ $slug ] : array();
$group_data = $credits['groups'][ $slug ] ?? array();
$credits_data = $credits['data'];
if ( ! count( $group_data ) ) {
return;
Expand Down
12 changes: 6 additions & 6 deletions src/wp-admin/includes/image-edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ function wp_image_editor( $post_id, $msg = false ) {
<input type="hidden" id="imgedit-history-<?php echo $post_id; ?>" value="" />
<input type="hidden" id="imgedit-undone-<?php echo $post_id; ?>" value="0" />
<input type="hidden" id="imgedit-selection-<?php echo $post_id; ?>" value="" />
<input type="hidden" id="imgedit-x-<?php echo $post_id; ?>" value="<?php echo isset( $meta['width'] ) ? $meta['width'] : 0; ?>" />
<input type="hidden" id="imgedit-y-<?php echo $post_id; ?>" value="<?php echo isset( $meta['height'] ) ? $meta['height'] : 0; ?>" />
<input type="hidden" id="imgedit-x-<?php echo $post_id; ?>" value="<?php echo $meta['width'] ?? 0; ?>" />
<input type="hidden" id="imgedit-y-<?php echo $post_id; ?>" value="<?php echo $meta['height'] ?? 0; ?>" />

<div id="imgedit-crop-<?php echo $post_id; ?>" class="imgedit-crop-wrap">
<div class="imgedit-crop-grid"></div>
Expand Down Expand Up @@ -154,10 +154,10 @@ function wp_image_editor( $post_id, $msg = false ) {
_e( 'scale height' );
?>
</label>
<input type="number" step="1" min="0" max="<?php echo isset( $meta['width'] ) ? $meta['width'] : ''; ?>" aria-describedby="imgedit-scale-warn-<?php echo $post_id; ?>" id="imgedit-scale-width-<?php echo $post_id; ?>" onkeyup="imageEdit.scaleChanged(<?php echo $post_id; ?>, 1, this)" onblur="imageEdit.scaleChanged(<?php echo $post_id; ?>, 1, this)" value="<?php echo isset( $meta['width'] ) ? $meta['width'] : 0; ?>" />
<input type="number" step="1" min="0" max="<?php echo $meta['width'] ?? ''; ?>" aria-describedby="imgedit-scale-warn-<?php echo $post_id; ?>" id="imgedit-scale-width-<?php echo $post_id; ?>" onkeyup="imageEdit.scaleChanged(<?php echo $post_id; ?>, 1, this)" onblur="imageEdit.scaleChanged(<?php echo $post_id; ?>, 1, this)" value="<?php echo $meta['width'] ?? 0; ?>" />
<span class="imgedit-separator" aria-hidden="true">&times;</span>
<label for="imgedit-scale-height-<?php echo $post_id; ?>" class="screen-reader-text"><?php _e( 'scale height' ); ?></label>
<input type="number" step="1" min="0" max="<?php echo isset( $meta['height'] ) ? $meta['height'] : ''; ?>" aria-describedby="imgedit-scale-warn-<?php echo $post_id; ?>" id="imgedit-scale-height-<?php echo $post_id; ?>" onkeyup="imageEdit.scaleChanged(<?php echo $post_id; ?>, 0, this)" onblur="imageEdit.scaleChanged(<?php echo $post_id; ?>, 0, this)" value="<?php echo isset( $meta['height'] ) ? $meta['height'] : 0; ?>" />
<input type="number" step="1" min="0" max="<?php echo $meta['height'] ?? ''; ?>" aria-describedby="imgedit-scale-warn-<?php echo $post_id; ?>" id="imgedit-scale-height-<?php echo $post_id; ?>" onkeyup="imageEdit.scaleChanged(<?php echo $post_id; ?>, 0, this)" onblur="imageEdit.scaleChanged(<?php echo $post_id; ?>, 0, this)" value="<?php echo $meta['height'] ?? 0; ?>" />
<button id="imgedit-scale-button" type="button" onclick="imageEdit.action(<?php echo "$post_id, '$nonce'"; ?>, 'scale')" class="button button-primary"><?php esc_html_e( 'Scale' ); ?></button>
</div>
<span class="imgedit-scale-warn" id="imgedit-scale-warn-<?php echo $post_id; ?>"><span class="dashicons dashicons-warning" aria-hidden="true"></span><?php esc_html_e( 'Images cannot be scaled to a size larger than the original.' ); ?></span>
Expand Down Expand Up @@ -744,10 +744,10 @@ function image_edit_apply_changes( $image, $changes ) {
$w = $size['width'];
$h = $size['height'];

$scale = isset( $sel->r ) ? $sel->r : 1 / _image_get_preview_ratio( $w, $h ); // Discard preview scaling.
$scale = $sel->r ?? 1 / _image_get_preview_ratio( $w, $h ); // Discard preview scaling.
$image->crop( (int) ( $sel->x * $scale ), (int) ( $sel->y * $scale ), (int) ( $sel->w * $scale ), (int) ( $sel->h * $scale ) );
} else {
$scale = isset( $sel->r ) ? $sel->r : 1 / _image_get_preview_ratio( imagesx( $image ), imagesy( $image ) ); // Discard preview scaling.
$scale = $sel->r ?? 1 / _image_get_preview_ratio( imagesx( $image ), imagesy( $image ) ); // Discard preview scaling.
$image = _crop_image_resource( $image, $sel->x * $scale, $sel->y * $scale, $sel->w * $scale, $sel->h * $scale );
}
break;
Expand Down
4 changes: 2 additions & 2 deletions src/wp-admin/includes/meta-boxes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,7 +1265,7 @@ function xfn_check( $xfn_relationship, $xfn_value = '', $deprecated = '' ) {
_deprecated_argument( __FUNCTION__, '2.5.0' ); // Never implemented.
}

$link_rel = isset( $link->link_rel ) ? $link->link_rel : '';
$link_rel = $link->link_rel ?? '';
$link_rels = preg_split( '/\s+/', $link_rel );

// Mark the specified value as checked if it matches the current link's relationship.
Expand Down Expand Up @@ -1454,7 +1454,7 @@ function link_advanced_meta_box( $link ) {
</tr>
<tr>
<th scope="row"><label for="link_notes"><?php _e( 'Notes' ); ?></label></th>
<td><textarea name="link_notes" id="link_notes" rows="10"><?php echo ( isset( $link->link_notes ) ? $link->link_notes : '' ); // textarea_escaped ?></textarea></td>
<td><textarea name="link_notes" id="link_notes" rows="10"><?php echo ( $link->link_notes ?? '' ); // textarea_escaped ?></textarea></td>
</tr>
<tr>
<th scope="row"><label for="link_rating"><?php _e( 'Rating' ); ?></label></th>
Expand Down
Loading
Loading