Skip to content

Conversation

@vladvelici
Copy link
Contributor

@vladvelici vladvelici commented Jan 6, 2026

https://ably.atlassian.net/browse/FTF-266


Note

Creates a dedicated push notifications command group and migrates APNS certificate management into it.

  • New push topic with push:set-apns-p12 command; examples and command class names/parse references updated
  • Removed apps set-apns-p12 example from apps topic
  • Added anonymous web CLI restriction for push* commands in src/base-command.ts
  • New/updated unit tests under test/unit/commands/push/set-apns-p12.test.ts validating success and error paths

Written by Cursor Bugbot for commit cb82c96. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • New Features

    • Introduced a new push notifications command group to manage Ably Push Notifications settings and features.
    • Added the push:set-apns-p12 command to configure APNS P12 certificates within the new command group.
  • Chores

    • Reorganized CLI structure by moving APNS certificate configuration command from the apps group to the new push notifications group.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Jan 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
cli-web-cli Ready Ready Preview, Comment Jan 6, 2026 4:42pm

@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

Walkthrough

The APNS P12 certificate command is being reorganized from the apps command group to a new dedicated push command group. Command invocation changes from ably apps set-apns-p12 to ably push set-apns-p12, with corresponding class renames and test updates. No functional behavior changes.

Changes

Cohort / File(s) Summary
Apps command cleanup
src/commands/apps/index.ts
Removed example invocation from apps command examples
Push command group creation
src/commands/push/index.ts
New PushIndexCommand class created; extends BaseTopicCommand with topicName "push" and commandGroup "push notifications"
APNS command migration
src/commands/push/set-apns-p12.ts
Class renamed from AppsSetApnsP12Command to PushSetApnsP12Command; all internal references and user-facing examples updated from "apps" to "push"
Test suite updates
test/unit/commands/push/set-apns-p12.test.ts
Command name references updated from "apps:set-apns-p12" to "push:set-apns-p12" across describe blocks and test invocations

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 From apps to push, our commands now fly,
A new group emerges, reaching for the sky,
The APNS command finds its rightful place,
Where push notifications set the pace! 📱✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: creating a new push command group and moving the set-apns-p12 command into it.
Linked Issues check ✅ Passed The PR fully implements FTF-266 by creating a push command group and moving ably apps set-apns-p12 to ably push set-apns-p12.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objective of creating a push command group and relocating the APNS P12 command.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch push-command-group-FTF-266

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants