Move credentials and options to json config file #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atiq-cs
force-pushed
the
AddJsonSupportedForCredentialsAndSettings
branch
3 times, most recently
from
94f6242 to
8dfe2c3
Compare
Contributor
Author
|
Just saw a bunch of nullable warning popped up. Please let me know if you want me to fix them before proceeding with this. @abock Thanks again :) |
Owner
|
Yeah, I think this one needs a bit of cleanup around nullability andj to generally embrace the most modern C# paradigms. |
Contributor
Author
|
Sounds good. Let me update this and get back to you. |
atiq-cs
force-pushed
the
AddJsonSupportedForCredentialsAndSettings
branch
2 times, most recently
from
3459aee to
f20e9b9
Compare
Contributor
Author
|
Updated the PR. Here's build status (nullable warnings removed), Main Project, Driver project, |
…le program can be published to public repositories i.e., github In doing so, - provide a list of patterns in config so that internal / confidential strings can be put there - add namespace 'WPExportApp' to share it with JsonConfig class - add unicode examples: weird char replacements And, - comment 'CustomMetadata' out, for actual applications In addition, - update framework to 7.0 - add Nullable Annotations for System.Linq (ref, https://stackoverflow.com/questions/58670909/nullable-reference-type-information-not-exposed-from-firstordefault) Nits - update Copyright - update dep nuget packages // Initial PR Date: 11-21-2021
atiq-cs
force-pushed
the
AddJsonSupportedForCredentialsAndSettings
branch
from
f20e9b9 to
2a7bbbe
Compare
Contributor
Author
|
Let me know what you think about the fix! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move credentials and options to json config file so that driver program/project can be published to public repositories i.e., github
More details in commit log.