Pagination improved in the UI #1761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishi Garg <rishigarg2503@gmail.com>
…ilities.utils Signed-off-by: Rishi Garg <rishigarg2503@gmail.com>
Signed-off-by: Rishi Garg <rishigarg2503@gmail.com>
Author
|
hi @tdruez , I have completed this pull request please review it whenever you have some time to do so. I'll fix the documentation error till then please tell me if any further changes are needed in the code. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous closed pull request : #1625
Issue Addressed : #1616 #1617
Files Updated
Fixed pagination test assertions in
test_view.pyUpdated test cases in
test_pagination.pyCleaned up formatting in
pagination.htmladded pagination mixin in
pagination.pyTesting
All tests pass and provide better coverage of edge cases and security scenarios.
Work Left:
Test the same pagination mixin code on Scancode.io
Signed-off-by: Rishi Garg rishigarg2503@gmail.com