Updated Makefiles to build without ADE. Ignore files created as part … #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the build process.
Collaborator
|
Hi Dave, Makefile for kernext also need to be updated to compile kernext source code. Thanks, |
akhilesh2410
reviewed
Feb 7, 2018
Collaborator
akhilesh2410
left a comment
akhilesh2410
left a comment
There was a problem hiding this comment.
I have added some review comment on this PR, Please have a look.
| .include <${RULES_MK}> | ||
| #.include <${RULES_MK}> | ||
| all: | ||
| for i in $(SUBDIRS); do \ |
Collaborator
There was a problem hiding this comment.
SUBDIR should also have "lib/methods" directory to compile cfg_ipf utility.
Collaborator
There was a problem hiding this comment.
We can add for "sbin/64" as well if required.
| ILIST = ${PROGRAMS} IPFL.README | ||
| IPFL.README_IDIR = /usr/lpp/ipfl/ | ||
| IDIR = /usr/sbin/ | ||
|
|
Collaborator
There was a problem hiding this comment.
These changes will not invoke Makefile presents in "./64" directory.
Current makefile can create 64 bit binary for all utilities,but then we will not have binary with <binary_name> and <binary_name>64 ,based on the architecture(i.e. 32 bit and 64 bit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of the build process.
These changes get the user-mode code to build, but don't touch the kernel extension code.