Skip to content

build: switch Node.js toolchain to derive version from .nvmrc [patch] #32576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crisbeto merged 2 commits into from
Dec 19, 2025
Merged

build: switch Node.js toolchain to derive version from .nvmrc [patch] #32576

crisbeto merged 2 commits into from
Dec 19, 2025

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Dec 19, 2025

Remove hardcoded node.js version

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 19, 2025
@pullapprove pullapprove bot requested a review from tjshiu December 19, 2025 09:55
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 19, 2025
@alan-agius4 alan-agius4 removed the request for review from tjshiu December 19, 2025 12:39
@pullapprove pullapprove bot requested a review from tjshiu December 19, 2025 12:39
@alan-agius4 alan-agius4 changed the title build: switch Node.js toolchain to derive version from .nvmrc. build: switch Node.js toolchain to derive version from .nvmrc [patch] Dec 19, 2025
@alan-agius4
build: add pnpm extension with specified version and integrity
b80ffe5 
Ensure that the same version of pnpm is used.
josephperrott
josephperrott approved these changes Dec 19, 2025
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 19, 2025
@alan-agius4 alan-agius4 removed the request for review from tjshiu December 19, 2025 17:28
@crisbeto crisbeto merged commit 6080def into angular:21.0.x Dec 19, 2025
26 checks passed
@crisbeto
Copy link
Member

crisbeto commented Dec 19, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the nvm-bazel-patch branch December 19, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alan-agius4 @crisbeto @josephperrott