-
Notifications
You must be signed in to change notification settings - Fork 0
Zizmor - Fix CI warnings with template injection and concurrency #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 7 7
Lines 802 802
=======================================
Hits 760 760
Misses 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| default-days: 5 | ||
| semver-patch-days: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reasoning behind having a shorter cooldown period for patches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patches tend to be smaller in scope, so easier to review diffs, and they're usually the change that's produced to fix security issues where we do want a faster throughout.
That said we can happily change it if we prefer, this was a first pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion, I was just curious. For other repos I think I had only defined a default cooldown of 7 days, regardless of the semver version. And I cannot really remember if there was consensus at the PyAnsys level.
I suppose a supply chain attack is more likely to be achieved via a patch than a major release (to maximize reach), so from a security perspective I would be inclined to think that patches are more vulnerable. But I suppose there isn't much difference between 3 days and 5 days cooldown in that context.
Fix zizmor warnings from 2025/12/30T00:16:29Z
Workflow concurrency improvements:
concurrencyconfiguration to.github/workflows/ci_cd.yml,.github/workflows/dependabot_approve.yml, and.github/workflows/security_checks.ymlto ensure that only one workflow run per pull request or ref is active at a time, canceling any in-progress runs for the same group. [1] [2] [3]Dependabot configuration enhancements:
cooldownperiod in.github/dependabot.ymlfor bothpipandgithub-actionsecosystems, settingdefault-daysto 5 andsemver-patch-daysto 3, to reduce the risk of supply chain attacks. [1] [2]Dependabot approval workflow fixes:
dependabot_approve.ymlworkflow to use explicit variables (REPOSITORY,EVENT_NUMBER,PR_URL) to reduce the risk of code injection attacks.