GH-48673: [C++] Fix ToStringWithoutContextLines to check for :\d+ pattern before removing lines

[HyukjinKwon]

Rationale for this change

This PR proposes to fix the todo

arrow/cpp/src/arrow/status.cc

Lines 131 to 134 in 7ebc88c

	// TODO: We may want to check /:\d+ /
	if (message.find(":", last_new_line_position) == std::string::npos) {
	break;
	}

which would allows a better parsing for line numbers.

I could not find the relevant example to demonstrate within this project but assume that we have a test such as:

(Generated by ChatGPT)

TEST(BlockParser, ErrorMessageWithColonsPreserved) {
  Status st(StatusCode::Invalid,
            "CSV parse error: Row #2: Expected 2 columns, got 3: 12:34:56,key:value,data\n"
            "Error details: Time format: 12:34:56, Key: value\n"
            "parser_test.cc:940  Parse(parser, csv, &out_size)");

  std::string expected_msg =
      "Invalid: CSV parse error: Row #2: Expected 2 columns, got 3: 12:34:56,key:value,data\n"
      "Error details: Time format: 12:34:56, Key: value";

  ASSERT_RAISES_WITH_MESSAGE(Invalid, expected_msg, st);
}

// Test with URL-like data (another common case with colons)
TEST(BlockParser, ErrorMessageWithURLPreserved) {
  Status st(StatusCode::Invalid,
            "CSV parse error: Row #2: Expected 1 columns, got 2: http://arrow.apache.org:8080/api,data\n"
            "URL: http://arrow.apache.org:8080/api\n"
            "parser_test.cc:974  Parse(parser, csv, &out_size)");

  std::string expected_msg =
      "Invalid: CSV parse error: Row #2: Expected 1 columns, got 2: http://arrow.apache.org:8080/api,data\n"
      "URL: http://arrow.apache.org:8080/api";

  ASSERT_RAISES_WITH_MESSAGE(Invalid, expected_msg, st);
}

then it fails.

What changes are included in this PR?

Fixed Status::ToStringWithoutContextLines() to only remove context lines matching the filename:line pattern (:\d+), preventing legitimate error messages containing colons from being incorrectly stripped.

Are these changes tested?

Manually tested, and unittests were added, with cmake .. --preset ninja-debug -DARROW_EXTRA_ERROR_CONTEXT=ON.

Are there any user-facing changes?

No, test-only.

• GitHub Issue: [C++] Fix ToStringWithoutContextLines to check for :\d+ pattern before removing lines #48673

[github-actions]

⚠️ GitHub issue #48673 has been automatically assigned in GitHub to PR creator.