GH-48684: [C++] Update MakeListArray to use ListArray::FromArrays instead of constructor #48685
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HyukjinKwon
force-pushed
the
GH-48684
branch
3 times, most recently
from
f487b62 to
96520a1
Compare
Member
Author
|
R test failure should not be related to this .. I created an issue and started working on it to make it less flaky #48690 |
…ys instead of constructor
HyukjinKwon
force-pushed
the
GH-48684
branch
from
96520a1 to
64fe216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
arrow/cpp/src/arrow/ipc/test_common.cc
Line 175 in 0c694e7
This todo was added: 1541a08 (2017) and resolved by 91aeae8 (2022).
What changes are included in this PR?
This PR proposes to use
ArrayType::FromArraysinstead of manual creation and validation.Are these changes tested?
Existing tests should cover this.
Are there any user-facing changes?
No, test-only.