GH-47721: [C++][FlightRPC] Followup to remove unncessary std::move to resolve compliation flakiness #48687
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
lidavidm
approved these changes
Dec 30, 2025
github-actions
bot
added
awaiting merge
…ove to resolve compliation flakiness
HyukjinKwon
force-pushed
the
GH-47721-followyuo
branch
from
2593cb3 to
6d3fb0d
Compare
Member
Author
|
Tests passed! |
lidavidm
approved these changes
Dec 30, 2025
Member
|
Thanks for catching this! Happy New Year! |
Member
Author
|
You know what you're super awesomeness 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes compilation error on macOS:
-Wpessimizing-movewarning.std::move()on a ternary expression prevents copy elision.shared_ptrassignment already handles moves automatically, sostd::moveis unnecessary and hurts optimization.What changes are included in this PR?
Removed
std::move()from ternary expression inColumnMetadataconstructor (cpp/src/arrow/flight/sql/column_metadata.cc:62). Behavior unchanged - still ensuresmetadata_map_is never null.Are these changes tested?
Yes. Existing tests cover
ColumnMetadatafunctionality. No behavioral changes, so tests continue to pass.Are there any user-facing changes?
No. Compilation fix only. Behavior identical, may have slight performance improvement from better compiler optimizations.