-
Notifications
You must be signed in to change notification settings - Fork 4.1k
build(test): generate per-file brpc cc_test to improve Bazel UT coverage #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: yexiaochuan <tap91624@gmail.com>
… license header Signed-off-by: yexiaochuan <tap91624@gmail.com>
Signed-off-by: yexiaochuan <tap91624@gmail.com>
|
Is it possible to use bazel tests with github workflows? |
|
Sure, i"ll work on workflow |
|
This code looks no problem, but I don't know why the ci-linux workflow is not runned… |
Signed-off-by: yexiaochuan <tap91624@gmail.com>
| - name: run bazel tests | ||
| run: bazel test --test_output=errors --verbose_failures -- //test/... | ||
|
|
||
| clang-bazel-unittest: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StackTraceTest.find_symbol seems to fail in clang14. It is recommended to use clang12 with sudo apt-get install -y clang-12 lldb-12 lld-12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And --action_env=CC=clang-12.
chenBright
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build on Macos has been fixed in master. Please update and rebase master.
What problem does this PR solve?
Part: #2904
Problem Summary:
test/brpc_http_rpc_protocol_unittest.cpp的修改是为了兼容bazel指定的 更高的proto版本 基于Bazel编译的UT不完善 #2904 (comment)What is changed and the side effects?
Changed:
brpc/test/CMakeLists.txt
Line 253 in c24e641
Side effects:
Performance effects:无
Breaking backward compatibility: 无
Check List: