allocator hangs that may occur after calling the C++ API MallocExtension::instance()->ReleaseFreeMemory() on some tcmalloc versions/distros.
#3139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
MallocExtension::instance()->ReleaseFreeMemory()on some tcmalloc versions/distros.Issue Number: resolves #200
Problem Summary:
MallocExtension::instance()may not be reliably overridden in some environments (e.g., Fedora 26), and callingReleaseFreeMemory()via that path has been observed to hang subsequent allocations on tcmalloc 1.7/2.5.MallocExtension_ReleaseFreeMemory()at runtime; this PR adds tests to prevent regressions and to make verification straightforward.What is changed and the side effects?
Changed:
test/brpc_tcmalloc_release_unittest.cppthat:MallocExtension_ReleaseFreeMemory(weakly referenced) → alloc/free again, with a 10s timeout guard to detect hangs.tcmalloc_release_test.cc(uses a weak symbol so it runs with or without libtcmalloc).Side effects:
Performance effects:
malloc_trimon Linux.Breaking backward compatibility: