Skip to content

Conversation

@kazantsev-maksim
Copy link
Contributor

Which issue does this PR close?

Part of: #2955

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.61%. Comparing base (f09f8af) to head (16b0c6c).
⚠️ Report is 805 commits behind head on main.

Files with missing lines Patch % Lines
...rc/main/scala/org/apache/comet/serde/structs.scala 50.00% 1 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3011      +/-   ##
============================================
+ Coverage     56.12%   59.61%   +3.48%     
- Complexity      976     1374     +398     
============================================
  Files           119      167      +48     
  Lines         11743    15494    +3751     
  Branches       2251     2573     +322     
============================================
+ Hits           6591     9236    +2645     
- Misses         4012     4959     +947     
- Partials       1140     1299     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

customStrings: Seq[String] = Seq.empty,
maxStringLength: Int = 8)
maxStringLength: Int = 8,
generateInfinity: Boolean = true)
Copy link
Contributor Author

@kazantsev-maksim kazantsev-maksim Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comet to_json does not support NaN, +Infinity, -Infinity values for numeric types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants