-
Notifications
You must be signed in to change notification settings - Fork 265
Chore: to_json unit/benchmark tests #3011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 768b3e9.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3011 +/- ##
============================================
+ Coverage 56.12% 59.61% +3.48%
- Complexity 976 1374 +398
============================================
Files 119 167 +48
Lines 11743 15494 +3751
Branches 2251 2573 +322
============================================
+ Hits 6591 9236 +2645
- Misses 4012 4959 +947
- Partials 1140 1299 +159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| customStrings: Seq[String] = Seq.empty, | ||
| maxStringLength: Int = 8) | ||
| maxStringLength: Int = 8, | ||
| generateInfinity: Boolean = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comet to_json does not support NaN, +Infinity, -Infinity values for numeric types.
Which issue does this PR close?
Part of: #2955
Rationale for this change
What changes are included in this PR?
How are these changes tested?