chore: Improve support - benchmarking suite #3014
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderfender
changed the title
Contributor
Author
|
@andygrove , benchmarks supporting ANSI mode had no |
Contributor
Author
|
Refactoring to not pass along both SQLConf and isANSIEnabled |
coderfender
commented
Dec 29, 2025
| /** Runs function `f` with Comet on and off. */ | ||
| final def runWithComet(name: String, cardinality: Long)(f: => Unit): Unit = { | ||
| val benchmark = new Benchmark(name, cardinality, output = output) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
this is no longer being used and needed as well IMO
coderfender
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3013
Rationale for this change
What changes are included in this PR?
How are these changes tested?