Introduce TypeSignatureClass::Any
#19485
Merged
+42
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
github-actions
bot
added
the
documentation
Jefffrey
commented
Dec 25, 2025
| SELECT arrow_cast('1') | ||
|
|
||
| query error DataFusion error: Execution error: arrow_cast requires its second argument to be a non\-empty constant string | ||
| query error Expect TypeSignatureClass::Native\(LogicalType\(Native\(String\), String\)\) but received NativeType::Int64, DataType: Int64 |
Contributor
Author
There was a problem hiding this comment.
Probably should start looking in #19004 properly to try pretty up these new error messages 🤔
Contributor
There was a problem hiding this comment.
These are really ugly I agree it would be nice if it was neater. But the current status quo is not good so this is no better or worse imo.
adriangb
approved these changes
Dec 28, 2025
Comment on lines
+359
to
+360
| // TODO: might be too much info to return every single type here | ||
| // maybe https://github.com/apache/datafusion/issues/14761 will help here? |
| SELECT arrow_cast('1') | ||
|
|
||
| query error DataFusion error: Execution error: arrow_cast requires its second argument to be a non\-empty constant string | ||
| query error Expect TypeSignatureClass::Native\(LogicalType\(Native\(String\), String\)\) but received NativeType::Int64, DataType: Int64 |
Contributor
There was a problem hiding this comment.
These are really ugly I agree it would be nice if it was neater. But the current status quo is not good so this is no better or worse imo.
Contributor
Author
|
Thanks @adriangb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
TypeSignatureClass::Anyvariant #19438Rationale for this change
See issue.
What changes are included in this PR?
Add new
TypeSignatureClassvariantAnyand refactorarrow_typeofandarrow_metadatafunction signatures to use this.Are these changes tested?
Existing tests.
Are there any user-facing changes?
No.