perf: optimize trim functions to reuse pattern buffer #19555
+69
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Replace per-row Vec allocation with a reusable buffer in trim functions (ltrim, rtrim, btrim).
The previous implementation allocated a Vec for the pattern on every row, which was inefficient. This optimization introduces a pattern_buf that is allocated once and reused across all rows by clearing and refilling it.
Changes:
Benchmark results for ltrim (size=1024):
Benchmark results for ltrim (size=4096):
The optimization shows consistent 28-40% improvement across most workloads by eliminating per-row Vec allocations. This applies to all trim variants (ltrim, rtrim, btrim) as they share the same underlying implementation.
Are these changes tested?
Are there any user-facing changes?