Fix IndexOutOfBoundsException in ArrowArrayWriter when element count exceeds INITIAL_CAPACITY #2291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: binary-signal <binary-signal@github.noreply.com>
- Make INITIAL_CAPACITY public in ArrowWriter to allow access from ArrowArrayWriter - Replace hardcoded handleSafe=true with dynamic check based on fieldIndex - Only use safe write when fieldIndex exceeds INITIAL_CAPACITY, improving performance for arrays with indices below the initial capacity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on @binary-signal's #2165. Thanks to him for the detailed root cause analysis and fix; I've only added a small optimization on top of his commit.
Purpose
Linked issue: close #2164
Brief change log
Tests
API and Format
Documentation