Skip to content

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Dec 26, 2025

…store file

@Apache9 Apache9 requested a review from wchevreuil December 26, 2025 16:42
@Apache9 Apache9 self-assigned this Dec 26, 2025
@Apache9 Apache9 requested a review from taklwu December 26, 2025 16:42
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the references for files that got completed evicted? E.g. after a file got evicted because of deletion? Otherwise, if an RS is up for a long period, it could lead to memory accumulation.

@Apache9
Copy link
Contributor Author

Apache9 commented Dec 28, 2025

Should we remove the references for files that got completed evicted? E.g. after a file got evicted because of deletion? Otherwise, if an RS is up for a long period, it could lead to memory accumulation.

All the String references in FastStringPool are weak references, they will be GCed when there are no other references.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 56s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for branch
+1 💚 mvninstall 3m 36s master passed
+1 💚 compile 4m 13s master passed
+1 💚 checkstyle 1m 17s master passed
+1 💚 spotbugs 2m 15s master passed
+1 💚 spotless 0m 50s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 10s the patch passed
+1 💚 compile 4m 13s the patch passed
+1 💚 javac 4m 13s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 14s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 1m 0s hbase-server: The patch generated 0 new + 8 unchanged - 1 fixed = 8 total (was 9)
+1 💚 spotbugs 2m 26s the patch passed
+1 💚 hadoopcheck 12m 21s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 48s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 19s The patch does not generate ASF License warnings.
48m 22s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7576/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7576
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 853be7337fe7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 252b249
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7576/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 59s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 3m 7s master passed
+1 💚 compile 1m 18s master passed
+1 💚 javadoc 0m 43s master passed
+1 💚 shadedjars 6m 7s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 10s the patch passed
+1 💚 compile 1m 18s the patch passed
+1 💚 javac 1m 18s the patch passed
+1 💚 javadoc 0m 42s the patch passed
+1 💚 shadedjars 6m 8s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 2m 20s hbase-common in the patch passed.
-1 ❌ unit 212m 7s /patch-unit-hbase-server.txt hbase-server in the patch failed.
246m 32s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7576/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7576
Optional Tests javac javadoc unit compile shadedjars
uname Linux 81ca3cb79c5a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 252b249
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7576/3/testReport/
Max. process+thread count 4042 (vs. ulimit of 30000)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7576/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 1a3e371 into apache:master Dec 28, 2025
1 check failed
Apache9 added a commit that referenced this pull request Dec 28, 2025
…store file (#7576)

Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 1a3e371)
Apache9 added a commit that referenced this pull request Dec 28, 2025
…store file (#7576)

Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 1a3e371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants