refactor: remove obsolete format string workaround #448
+2
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove workaround for old Clang/libc++ bug where "<{}>" in format
strings was incorrectly parsed. Modern compilers handle this correctly.
Changes:
- Simplify ListType::ToString() to use direct format string
- Simplify MapType::ToString() to use direct format string
- Remove XXX comments about the workaround
The existing tests will verify this works correctly on current compilers.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
zhjwpku
approved these changes
Dec 29, 2025
wgtmac
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove workaround for old Clang/libc++ bug where "<{}>" in format strings was incorrectly parsed. Modern compilers handle this correctly.
Changes:
The existing tests will verify this works correctly on current compilers.