-
Notifications
You must be signed in to change notification settings - Fork 656
testing/cmocka: Compile cmocka as a libary only by default #3270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
linguini1
wants to merge
1
commit into
apache:master
Choose a base branch
from
linguini1:cmocka-as-lib
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Build is failing because sim:citest needs the change in apache/nuttx#17653 |
a9e2457 to
ffea164
Compare
This commit introduces a Kconfig switch to include the cmocka binary built from cmocka_main.c. The default behaviour is now changed so that cmocka is built as a library only, which would be the desired behaviour for users creating their own cmocka projects. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
ffea164 to
8b390fe
Compare
xiaoxiang781216
approved these changes
Dec 26, 2025
Contributor
Author
|
Any ideas why the CI test is failing? It seems that the cmocka binary is present, just an assertion is failing. |
Contributor
|
@linguini1 it is saying that boards/risc-v/qemu-rv/rv-virt/configs/citest/logs/ is not tracked, not sure if it needs to be. Maybe @simbit18 or @lupyuen has some idea, they know more about the citest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit introduces a Kconfig switch to include the cmocka binary built from cmocka_main.c. The default behaviour is now changed so that cmocka is built as a library only, which would be the desired behaviour for users creating their own cmocka projects.
Impact
Cmocka is now only built as a library, so the
cmockabinary is no longerincluded by default.
PR (apache/nuttx#17653) to the NuttX kernel preserves the compilation of the
cmockabinary for the two existing defconfigs which use the cmocka application.Testing
Compilation of the cmocka libary without the binary using
sim:nshas a basis:Then, when disabling
CONFIG_TESTING_CMOCKA_ASLIB, the compilation is:and I can run the cmocka application on sim: