Skip to content

ci/platforms: bump Xtensa esp toolchain #16733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoxiang781216 merged 5 commits into from
Jul 18, 2025
Merged

ci/platforms: bump Xtensa esp toolchain #16733

xiaoxiang781216 merged 5 commits into from
Jul 18, 2025

Conversation

@simbit18
Copy link
Contributor

@simbit18 simbit18 commented Jul 16, 2025

Summary

Bump Xtensa esp-14.2.0_20241119

ci/platforms/darwin.sh
ci/platforms/darwin_arm64.sh
ci/platforms/linux.sh
ci/platforms/msys2.sh
ci/platforms/ubuntu.sh

aligned with docker #16643

Impact

Impact on user: No changes to user-facing functionality
Impact on build: Build process remains the same

Testing

CI

@github-actions github-actions bot added Area: Tooling Area: CI Size: M The size of the change in this PR is medium labels Jul 16, 2025
@simbit18 simbit18 changed the title ci/platforms: bump risc-v toolchain ci/platforms: bump Xtensa esp toolchain Jul 16, 2025
@simbit18
Copy link
Contributor Author

simbit18 commented Jul 16, 2025

@xiaoxiang781216 @fdcavalcanti This error does not depend on this PR

Configuration/Tool: esp32-devkitc/nxlooper
2025-07-16 12:35:17
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  340k  100  340k    0     0  1290k      0 --:--:-- --:--:-- --:--:-- 1290k

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100  496k  100  496k    0     0  2754k      0 --:--:-- --:--:-- --:--:-- 2754k
Traceback (most recent call last):
  File "/usr/local/bin/esptool.py", line 37, in <module>
    esptool._main()
  File "/usr/local/lib/python3.10/dist-packages/esptool/__init__.py", line 1170, in _main
    main()
  File "/usr/local/lib/python3.10/dist-packages/esptool/__init__.py", line 983, in main
    operation_func(args)
  File "/usr/local/lib/python3.10/dist-packages/esptool/cmds.py", line 1097, in elf2image
    image.save(args.output)
  File "/usr/local/lib/python3.10/dist-packages/esptool/bin_image.py", line 778, in save
    assert (f.tell() + 8 + self.ROM_LOADER.BOOTLOADER_FLASH_OFFSET) % (
AssertionError
make: *** [tools/Unix.mk:559: nuttx] Error 1
make: Target 'all' not remade because of errors.
  [1/1] Normalize esp32-devkitc/nxlooper

@simbit18
Copy link
Contributor Author

simbit18 commented Jul 16, 2025

@fdcavalcanti @tmedicci Do we need to update esptool?

@fdcavalcanti
Copy link
Contributor

fdcavalcanti commented Jul 16, 2025 •
edited
Loading

@fdcavalcanti @tmedicci Do we need to update esptool?

Not necessary, current toolchain version works with esptool v4.9.x.

@fdcavalcanti
Copy link
Contributor

fdcavalcanti commented Jul 16, 2025

@xiaoxiang781216 @fdcavalcanti This error does not depend on this PR

Configuration/Tool: esp32-devkitc/nxlooper
2025-07-16 12:35:17
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  340k  100  340k    0     0  1290k      0 --:--:-- --:--:-- --:--:-- 1290k

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100  496k  100  496k    0     0  2754k      0 --:--:-- --:--:-- --:--:-- 2754k
Traceback (most recent call last):
  File "/usr/local/bin/esptool.py", line 37, in <module>
    esptool._main()
  File "/usr/local/lib/python3.10/dist-packages/esptool/__init__.py", line 1170, in _main
    main()
  File "/usr/local/lib/python3.10/dist-packages/esptool/__init__.py", line 983, in main
    operation_func(args)
  File "/usr/local/lib/python3.10/dist-packages/esptool/cmds.py", line 1097, in elf2image
    image.save(args.output)
  File "/usr/local/lib/python3.10/dist-packages/esptool/bin_image.py", line 778, in save
    assert (f.tell() + 8 + self.ROM_LOADER.BOOTLOADER_FLASH_OFFSET) % (
AssertionError
make: *** [tools/Unix.mk:559: nuttx] Error 1
make: Target 'all' not remade because of errors.
  [1/1] Normalize esp32-devkitc/nxlooper

Weird.. I can build locally just fine with same esptool and GCC (14.2.0) version.
Maybe retry?

@simbit18
Copy link
Contributor Author

simbit18 commented Jul 16, 2025

@fdcavalcanti I re-run the jobs

@simbit18
Copy link
Contributor Author

simbit18 commented Jul 16, 2025 

====================================================================================
Configuration/Tool: esp32-devkitc/nxlooper
2025-07-16 15:21:52
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 59  340k   59  203k    0     0   509k      0 --:--:-- --:--:-- --:--:--  509k
100  340k  100  340k    0     0   817k      0 --:--:-- --:--:-- --:--:-- 8532k
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  496k  100  496k    0     0  1077k      0 --:--:-- --:--:-- --:--:-- 1077k
Traceback (most recent call last):
  File "/usr/local/bin/esptool.py", line 37, in <module>
    esptool._main()
  File "/usr/local/lib/python3.10/dist-packages/esptool/__init__.py", line 1170, in _main
    main()
  File "/usr/local/lib/python3.10/dist-packages/esptool/__init__.py", line 983, in main
    operation_func(args)
  File "/usr/local/lib/python3.10/dist-packages/esptool/cmds.py", line 1097, in elf2image
    image.save(args.output)
  File "/usr/local/lib/python3.10/dist-packages/esptool/bin_image.py", line 778, in save
    assert (f.tell() + 8 + self.ROM_LOADER.BOOTLOADER_FLASH_OFFSET) % (
AssertionError
make: *** [tools/Unix.mk:559: nuttx] Error 1
make: Target 'all' not remade because of errors.
  [1/1] Normalize esp32-devkitc/nxlooper

@fdcavalcanti @tmedicci Do we need to update esptool?

Not necessary, current toolchain version works with esptool v4.9.x.

@fdcavalcanti error still present we use this version

nuttx/tools/ci/docker/linux/Dockerfile

Line 383 in bc8ce39

RUN pip3 install esptool==4.8.dev4

@eren-terzioglu
Copy link
Contributor

eren-terzioglu commented Jul 16, 2025 •
edited
Loading 

====================================================================================
Configuration/Tool: esp32-devkitc/nxlooper
2025-07-16 15:21:52
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 59  340k   59  203k    0     0   509k      0 --:--:-- --:--:-- --:--:--  509k
100  340k  100  340k    0     0   817k      0 --:--:-- --:--:-- --:--:-- 8532k
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  496k  100  496k    0     0  1077k      0 --:--:-- --:--:-- --:--:-- 1077k
Traceback (most recent call last):
  File "/usr/local/bin/esptool.py", line 37, in <module>
    esptool._main()
  File "/usr/local/lib/python3.10/dist-packages/esptool/__init__.py", line 1170, in _main
    main()
  File "/usr/local/lib/python3.10/dist-packages/esptool/__init__.py", line 983, in main
    operation_func(args)
  File "/usr/local/lib/python3.10/dist-packages/esptool/cmds.py", line 1097, in elf2image
    image.save(args.output)
  File "/usr/local/lib/python3.10/dist-packages/esptool/bin_image.py", line 778, in save
    assert (f.tell() + 8 + self.ROM_LOADER.BOOTLOADER_FLASH_OFFSET) % (
AssertionError
make: *** [tools/Unix.mk:559: nuttx] Error 1
make: Target 'all' not remade because of errors.
  [1/1] Normalize esp32-devkitc/nxlooper

@fdcavalcanti @tmedicci Do we need to update esptool?

Not necessary, current toolchain version works with esptool v4.9.x.

@fdcavalcanti error still present we use this version

nuttx/tools/ci/docker/linux/Dockerfile

Line 383 in bc8ce39

RUN pip3 install esptool==4.8.dev4

You can upgrade to 4.8.1 for a while, it is the version I am using. We are testing v5.0.1 but it needs some time. Before v5,

@simbit18
Copy link
Contributor Author

simbit18 commented Jul 16, 2025

@eren-terzioglu Before updating the docker image it is necessary to do some tests now I cannot.

@fdcavalcanti
Copy link
Contributor

fdcavalcanti commented Jul 16, 2025

Yep, was able to replicate the issue. I'll look into it.

@fdcavalcanti
Copy link
Contributor

fdcavalcanti commented Jul 17, 2025

The current CI error is not related to this PR. We can move forward if you guys want.
Fix for CI error will come on different PR.

@simbit18
Copy link
Contributor Author

simbit18 commented Jul 17, 2025

@fdcavalcanti The documentation lists this version of esptool

pip install esptool>=4.8.1

https://nuttx.apache.org/docs/latest/platforms/xtensa/esp32/index.html#installing-esptool

Dockerfile

nuttx/tools/ci/docker/linux/Dockerfile

Line 383 in bc8ce39

RUN pip3 install esptool==4.8.dev4

Do we need to update it?

@fdcavalcanti
Copy link
Contributor

fdcavalcanti commented Jul 17, 2025

@fdcavalcanti The documentation lists this version of esptool

pip install esptool>=4.8.1

https://nuttx.apache.org/docs/latest/platforms/xtensa/esp32/index.html#installing-esptool

Dockerfile

nuttx/tools/ci/docker/linux/Dockerfile

Line 383 in bc8ce39

RUN pip3 install esptool==4.8.dev4

Do we need to update it?

Not necessary. We will soon update to version v5.0.1, so for now I would leave as is.

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Jul 18, 2025

@fdcavalcanti The documentation lists this version of esptool
pip install esptool>=4.8.1
https://nuttx.apache.org/docs/latest/platforms/xtensa/esp32/index.html#installing-esptool
Dockerfile

nuttx/tools/ci/docker/linux/Dockerfile

Line 383 in bc8ce39

RUN pip3 install esptool==4.8.dev4

Do we need to update it?

Not necessary. We will soon update to version v5.0.1, so for now I would leave as is.

@fdcavalcanti can you fix xtensa ci break today? ALL pr report this error now.

@xiaoxiang781216 xiaoxiang781216 merged commit be0057c into apache:master Jul 18, 2025
63 of 75 checks passed
@fdcavalcanti
Copy link
Contributor

fdcavalcanti commented Jul 18, 2025

@fdcavalcanti The documentation lists this version of esptool
pip install esptool>=4.8.1
https://nuttx.apache.org/docs/latest/platforms/xtensa/esp32/index.html#installing-esptool
Dockerfile

nuttx/tools/ci/docker/linux/Dockerfile

Line 383 in bc8ce39

RUN pip3 install esptool==4.8.dev4

Do we need to update it?

Not necessary. We will soon update to version v5.0.1, so for now I would leave as is.

@fdcavalcanti can you fix xtensa ci break today? ALL pr report this error now.

I can do a temporary fix, will send soon.

@simbit18 simbit18 deleted the simbit18-bumpesp branch July 22, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@fdcavalcanti fdcavalcanti fdcavalcanti approved these changes

+1 more reviewer

@eren-terzioglu eren-terzioglu eren-terzioglu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: CI Area: Tooling Size: M The size of the change in this PR is medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simbit18 @fdcavalcanti @eren-terzioglu @xiaoxiang781216