Skip to content

sched/task: Relocate the group ahead of the tcb to ensure the group drop logic #17578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anchao wants to merge 5 commits into
base: master
Choose a base branch
from
Open

sched/task: Relocate the group ahead of the tcb to ensure the group drop logic #17578

anchao wants to merge 5 commits into from

Conversation

@anchao
Copy link
Contributor

@anchao anchao commented Dec 21, 2025

Summary

sched/task: Relocate the group ahead of the tcb to ensure the group drop logic

Relocate the group ahead of the tcb to ensure that the relationship between
the group and tcb remains bound throughout the task lifecycle.
This eliminates the need to add excessive redundant checks to prevent erroneous release of the group.

Signed-off-by: chao an <anchao.archer@bytedance.com>

Impact

N/A

Testing

test log:

$ ./nuttx 

NuttShell (NSH) NuttX-10.4.0
nsh> 
nsh> 
nsh> hello
Test PASSED
nsh> hello
Test PASSED
nsh> 
nsh> 
nsh> 
nsh> 
nsh> free
      total       used       free    maxused    maxfree  nused  nfree name
   67108864    1787624   65321240    1923912   65321096     66      2 Umem
nsh> ostest
stdio_test: write fd=1
stdio_test: Standard I/O Check: printf
stdio_test: write fd=2
ostest_main: putenv(Variable1=BadValue3)
ostest_main: setenv(Variable1, GoodValue1, TRUE)
ostest_main: setenv(Variable2, BadValue1, FALSE)
ostest_main: setenv(Variable2, GoodValue2, TRUE)
ostest_main: setenv(Variable3, GoodValue3, FALSE)
ostest_main: setenv(Variable3, BadValue2, FALSE)
show_variable: Variable=Variable1 has value=GoodValue1
show_variable: Variable=Variable2 has value=GoodValue2
show_variable: Variable=Variable3 has value=GoodValue3
ostest_main: Started user_main at PID=9

user_main: Begin argument test
user_main: Started with argc=5
user_main: argv[0]="ostest"
user_main: argv[1]="Arg1"
user_main: argv[2]="Arg2"
user_main: argv[3]="Arg3"
user_main: argv[4]="Arg4"

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         1        1
mxordblk  3e289b0  3e289b0
uordblks   1d7650   1d7650
fordblks  3e289b0  3e289b0

user_main: getopt() test
getopt():  Simple test
getopt():  Invalid argument
getopt():  Missing optional argument
getopt_long():  Simple test
getopt_long():  No short options
getopt_long():  Argument for --option=argument
getopt_long():  Invalid long option
getopt_long():  Mixed long and short options
getopt_long():  Invalid short option
getopt_long():  Missing optional arguments
getopt_long_only():  Mixed long and short options
getopt_long_only():  Single hyphen long options

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         1        1
mxordblk  3e289b0  3e289b0
uordblks   1d7650   1d7650
fordblks  3e289b0  3e289b0

user_main: libc tests

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         1        1
mxordblk  3e289b0  3e289b0
uordblks   1d7650   1d7650
fordblks  3e289b0  3e289b0
show_variable: Variable=Variable1 has value=GoodValue1
show_variable: Variable=Variable2 has value=GoodValue2
show_variable: Variable=Variable3 has value=GoodValue3
show_variable: Variable=Variable1 has no value
show_variable: Variable=Variable2 has value=GoodValue2
show_variable: Variable=Variable3 has value=GoodValue3

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         1        2
mxordblk  3e289b0  3e289b0
uordblks   1d7650   1d7630
fordblks  3e289b0  3e289d0
show_variable: Variable=Variable1 has no value
show_variable: Variable=Variable2 has no value
show_variable: Variable=Variable3 has no value

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         2        2
mxordblk  3e289b0  3e289b0
uordblks   1d7630   1d7558
fordblks  3e289d0  3e28aa8

user_main: setvbuf test
setvbuf_test: Test NO buffering
setvbuf_test: Using NO buffering
setvbuf_test: Test default FULL buffering
setvbuf_test: Using default FULL buffering
setvbuf_test: Test FULL buffering, buffer size 64
setvbuf_test: Using FULL buffering, buffer size 64
setvbuf_test: Test FULL buffering, pre-allocated buffer
setvbuf_test: Using FULL buffering, pre-allocated buffer
setvbuf_test: Test LINE buffering, buffer size 64
setvbuf_test: Using LINE buffering, buffer size 64
setvbuf_test: Test FULL buffering, pre-allocated buffer
setvbuf_test: Using FULL buffering, pre-allocated buffer

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         2        2
mxordblk  3e289b0  3e289b0
uordblks   1d7558   1d7558
fordblks  3e28aa8  3e28aa8

user_main: /dev/null test
dev_null: Read 0 bytes from /dev/null
dev_null: Wrote 1024 bytes to /dev/null

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         2        2
mxordblk  3e289b0  3e289b0
uordblks   1d7558   1d7558
fordblks  3e28aa8  3e28aa8

user_main: task_restart test

Test task_restart()
restart_main: setenv(VarName, VarValue, TRUE)
restart_main: Started restart_main at PID=10
restart_main: Started with argc=4
restart_main: argv[0]="ostest"
restart_main: argv[1]="This is argument 1"
restart_main: argv[2]="Argument 2 here"
restart_main: argv[3]="Lastly, the 3rd argument"
restart_main: Variable=VarName has value=VarValue
restart_main: I am still here
restart_main: I am still here
restart_main: Started restart_main at PID=10
restart_main: Started with argc=4
restart_main: argv[0]="ostest"
restart_main: argv[1]="This is argument 1"
restart_main: argv[2]="Argument 2 here"
restart_main: argv[3]="Lastly, the 3rd argument"
restart_main: Variable=VarName has value=VarValue
restart_main: Started with argc=4
restart_main: argv[0]="ostest"
restart_main: argv[1]="This is argument 1"
restart_main: argv[2]="Argument 2 here"
restart_main: argv[3]="Lastly, the 3rd argument"
restart_main: Variable=VarName has value=VarValue
restart_main: Exiting

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         2        3
mxordblk  3e289b0  3e163c0
uordblks   1d7558   1e95b8
fordblks  3e28aa8  3e16a48

user_main: waitpid test

Test waitpid()
waitpid_start_child: Started waitpid_main at PID=11
waitpid_start_child: Started waitpid_main at PID=12
waitpid_start_child: Started waitpid_main at PID=13
waitpid_test: Waiting for PID=11 with waitpid()
waitpid_main: PID 11 Started
waitpid_main: PID 12 Started
waitpid_main: PID 13 Started
waitpid_main: PID 11 exitting with result=14
waitpid_main: PID 12 exitting with result=14
waitpid_main: PID 13 exitting with result=14
waitpid_test: PID 11 waitpid succeeded with stat_loc=0e00
waitpid_last: Waiting for PID=13 with waitpid()
waitpid_last: PASS: PID 13 waitpid failed with ECHILD.  That may be
              acceptable because child status is disabled on this thread.

Test waitid(P_PID)
waitpid_start_child: Started waitpid_main at PID=14
waitpid_start_child: Started waitpid_main at PID=15
waitpid_start_child: Started waitpid_main at PID=20
waitpid_test: Waiting for PID=14 with waitid()
waitpid_main: PID 14 Started
waitpid_main: PID 15 Started
waitpid_main: PID 20 Started
waitpid_main: PID 14 exitting with result=14
waitpid_main: PID 15 exitting with result=14
waitpid_main: PID 20 exitting with result=14
waitpid_test: waitid PID 14 succeeded with si_status=14
waitpid_last: Waiting for PID=20 with waitpid()
waitpid_last: PASS: PID 20 waitpid failed with ECHILD.  That may be
              acceptable because child status is disabled on this thread.

Test waitid(P_ALL)
waitpid_start_child: Started waitpid_main at PID=21
waitpid_start_child: Started waitpid_main at PID=22
waitpid_start_child: Started waitpid_main at PID=23
waitpid_test: Waiting for any child with waitid()
waitpid_main: PID 21 Started
waitpid_main: PID 22 Started
waitpid_main: PID 23 Started
waitpid_main: PID 21 exitting with result=14
waitpid_main: PID 22 exitting with result=14
waitpid_main: PID 23 exitting with result=14
waitpid_test: PID 21 waitid succeeded with si_status=14
waitpid_last: Waiting for PID=23 with waitpid()
waitpid_last: PASS: PID 23 waitpid failed with ECHILD.  That may be
              acceptable because child status is disabled on this thread.

Test wait()
waitpid_start_child: Started waitpid_main at PID=26
waitpid_start_child: Started waitpid_main at PID=27
waitpid_start_child: Started waitpid_main at PID=28
waitpid_test: Waiting for any child with wait()
waitpid_main: PID 26 Started
waitpid_main: PID 27 Started
waitpid_main: PID 28 Started
waitpid_main: PID 26 exitting with result=14
waitpid_main: PID 27 exitting with result=14
waitpid_main: PID 28 exitting with result=14
waitpid_test: PID 26 wait succeeded with stat_loc=0e00
waitpid_last: Waiting for PID=28 with waitpid()
waitpid_last: PASS: PID 28 waitpid failed with ECHILD.  That may be
              acceptable because child status is disabled on this thread.

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         3        5
mxordblk  3e163c0  3df1768
uordblks   1e95b8   20d5c8
fordblks  3e16a48  3df2a38

user_main: mutex test
Initializing mutex
Starting thread 1
Starting thread 2
		Thread1	Thread2
	Loops	32	32
	Errors	0	0

Testing moved mutex
Starting moved mutex thread 1
Starting moved mutex thread 2
		Thread1	Thread2
	Moved Loops	32	32
	Moved Errors	0	0

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         5        2
mxordblk  3df1768  3de62f0
uordblks   20d5c8   219c70
fordblks  3df2a38  3de6390

user_main: timed mutex test
mutex_test: Initializing mutex
mutex_test: Starting thread
pthread:  Started
pthread:  Waiting for lock or timeout
mutex_test: Unlocking
pthread:  Got the lock
pthread:  Waiting for lock or timeout
pthread:  Got the timeout.  Terminating
mutex_test: PASSED

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         2        2
mxordblk  3de62f0  3e18000
uordblks   219c70   1e7f60
fordblks  3de6390  3e180a0

user_main: cancel test
cancel_test: Test 1a: Normal Cancellation
cancel_test: Starting thread
start_thread: Initializing mutex
start_thread: Initializing cond
start_thread: Starting thread
start_thread: Yielding
sem_waiter: Taking mutex
sem_waiter: Starting wait for condition
cancel_test: Canceling thread
cancel_test: Joining
cancel_test: waiter exited with result=0xffffffffffffffff
cancel_test: PASS thread terminated with PTHREAD_CANCELED
cancel_test: Test 2: Asynchronous Cancellation
cancel_test: Starting thread
restart_thread: Destroying cond
restart_thread: Destroying mutex
restart_thread: Re-starting thread
start_thread: Initializing mutex
start_thread: Initializing cond
start_thread: Starting thread
start_thread: Yielding
asynch_waiter: Setting non-cancelable
asynch_waiter: Setting synchronous cancellation type
cancel_test: Canceling thread
cancel_test: Joining
asynch_waiter: Restoring cancelable state
asynch_waiter: Setting cancelable
cancel_test: waiter exited with result=0xffffffffffffffff
cancel_test: PASS thread terminated with PTHREAD_CANCELED
cancel_test: Test 3: Cancellation of detached thread
cancel_test: Re-starting thread
restart_thread: Destroying cond
restart_thread: Destroying mutex
restart_thread: Re-starting thread
start_thread: Initializing mutex
start_thread: Initializing cond
start_thread: Starting thread
start_thread: Yielding
sem_waiter: Taking mutex
sem_waiter: Starting wait for condition
cancel_test: Canceling thread
cancel_test: Joining
cancel_test: PASS pthread_join failed with status=ESRCH
cancel_test: Test 5: Non-cancelable threads
cancel_test: Re-starting thread (non-cancelable)
restart_thread: Destroying cond
restart_thread: Destroying mutex
restart_thread: Re-starting thread
start_thread: Initializing mutex
start_thread: Initializing cond
start_thread: Starting thread
start_thread: Yielding
sem_waiter: Taking mutex
sem_waiter: Starting wait for condition
sem_waiter: Setting non-cancelable
cancel_test: Canceling thread
cancel_test: Joining
sem_waiter: Releasing mutex
sem_waiter: Setting cancelable
cancel_test: waiter exited with result=0xffffffffffffffff
cancel_test: PASS thread terminated with PTHREAD_CANCELED
cancel_test: Test 6: Cancel message queue wait
cancel_test: Starting thread (cancelable)
restart_thread: Destroying cond
restart_thread: Destroying mutex
restart_thread: Re-starting thread
start_thread: Initializing mutex
start_thread: Initializing cond
start_thread: Starting thread
start_thread: Yielding
mqueue_waiter: Waiting to receive a message...
cancel_test: Canceling thread
cancel_test: Joining
cancel_test: waiter exited with result=0xffffffffffffffff
cancel_test: PASS thread terminated with PTHREAD_CANCELED
cancel_test: Test 7: Cancel signal wait
cancel_test: Starting thread (cancelable)
restart_thread: Destroying cond
restart_thread: Destroying mutex
restart_thread: Re-starting thread
start_thread: Initializing mutex
start_thread: Initializing cond
start_thread: Starting thread
start_thread: Yielding
sig_waiter: Waiting to receive signal...
cancel_test: Canceling thread
cancel_test: Joining
cancel_test: waiter exited with result=0xffffffffffffffff
cancel_test: PASS thread terminated with PTHREAD_CANCELED

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         2        3
mxordblk  3e18000  3e043c0
uordblks   1e7f60   1fbbc8
fordblks  3e180a0  3e04438

user_main: robust test
robust_test: Initializing mutex
robust_test: Starting thread
robust_waiter: Taking mutex
robust_waiter: Exiting with mutex
robust_test: Take the lock again
robust_test: Make the mutex consistent again.
robust_test: Take the lock again
robust_test: Joining
robust_test: waiter exited with result=0
robust_test: Test complete with nerrors=0

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         3        3
mxordblk  3e043c0  3e16570
uordblks   1fbbc8   1e9a18
fordblks  3e04438  3e165e8

user_main: semaphore test
sem_test: Initializing semaphore to 0
sem_test: Starting waiter thread 1
sem_test: Set thread 1 priority to 191
waiter_func: Thread 1 Started
waiter_func: Thread 1 initial semaphore value = 0
waiter_func: Thread 1 waiting on semaphore
sem_test: Starting waiter thread 2
sem_test: Set thread 2 priority to 128
waiter_func: Thread 2 Started
waiter_func: Thread 2 initial semaphore value = -1
waiter_func: Thread 2 waiting on semaphore
sem_test: Starting poster thread 3
sem_test: Set thread 3 priority to 64
poster_func: Thread 3 started
poster_func: Thread 3 semaphore value = -2
poster_func: Thread 3 posting semaphore
waiter_func: Thread 1 awakened
waiter_func: Thread 1 new semaphore value = -1
waiter_func: Thread 1 done
poster_func: Thread 3 new semaphore value = -1
poster_func: Thread 3 semaphore value = -1
poster_func: Thread 3 posting semaphore
waiter_func: Thread 2 awakened
waiter_func: Thread 2 new semaphore value = 0
waiter_func: Thread 2 done
poster_func: Thread 3 new semaphore value = 0
poster_func: Thread 3 done

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         3        4
mxordblk  3e16570  3df5560
uordblks   1e9a18   209578
fordblks  3e165e8  3df6a88

user_main: timed semaphore test
semtimed_test: Initializing semaphore to 0
semtimed_test: Waiting for two second timeout
semtimed_test: PASS: first test returned timeout
BEFORE: (1212278453 sec, 390682501 nsec)
AFTER:  (1212278455 sec, 400147663 nsec)
semtimed_test: Starting poster thread
semtimed_test: Set thread 1 priority to 191
semtimed_test: Starting poster thread 3
semtimed_test: Set thread 3 priority to 64
semtimed_test: Waiting for two second timeout
poster_func: Waiting for 1 second
poster_func: Posting
semtimed_test: PASS: sem_timedwait succeeded
BEFORE: (1212278455 sec, 400631500 nsec)
AFTER:  (1212278456 sec, 410215789 nsec)

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         4        4
mxordblk  3df5560  3e16570
uordblks   209578   1e8218
fordblks  3df6a88  3e17de8

user_main: condition variable test
cond_test: Initializing mutex
cond_test: Initializing cond
cond_test: Starting waiter
cond_test: Set thread 1 priority to 128
waiter_thread: Started
cond_test: Starting signaler
cond_test: Set thread 2 priority to 64
thread_signaler: Started
thread_signaler: Terminating
cond_test: signaler terminated, now cancel the waiter
cond_test: 	Waiter	Signaler
cond_test: Loops	32	32
cond_test: Errors	0	0
cond_test:
cond_test: 0 times, waiter did not have to wait for data
cond_test: 0 times, data was already available when the signaler run
cond_test: 0 times, the waiter was in an unexpected state when the signaler ran

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         4        4
mxordblk  3e16570  3e05d68
uordblks   1e8218   1f8bc8
fordblks  3e17de8  3e07438

user_main: pthread_exit() test
pthread_exit_test: Started pthread_exit_main at PID=59
pthread_exit_main 59: Starting pthread_exit_thread
pthread_exit_main 59: Sleeping for 5 seconds
pthread_exit_thread 60: Sleeping for 10 second
pthread_exit_main 59: Calling pthread_exit()
pthread_exit_thread 60: Still running...

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         4        3
mxordblk  3e05d68  3e05bc0
uordblks   1f8bc8   1fa3c8
fordblks  3e07438  3e05c38

user_main: pthread_rwlock test
pthread_rwlock: Initializing rwlock
pthread_exit_thread 60: Exiting

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         3        3
mxordblk  3e05bc0  3e05bc0
uordblks   1fa3c8   1e8240
fordblks  3e05c38  3e17dc0

user_main: pthread_rwlock_cancel test
pthread_rwlock_cancel: Starting test

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         3        3
mxordblk  3e05bc0  3e05d68
uordblks   1e8240   1f8bf0
fordblks  3e17dc0  3e07410

user_main: timed wait test
thread_waiter: Initializing mutex
timedwait_test: Initializing cond
timedwait_test: Starting waiter
timedwait_test: Set thread 2 priority to 177
thread_waiter: Taking mutex
thread_waiter: Starting 5 second wait for condition
timedwait_test: Joining
thread_waiter: pthread_cond_timedwait timed out
thread_waiter: Releasing mutex
thread_waiter: Exit with status 0x12345678
timedwait_test: waiter exited with result=0x12345678

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         3        3
mxordblk  3e05d68  3e16570
uordblks   1f8bf0   1e8240
fordblks  3e07410  3e17dc0

user_main: message queue test
mqueue_test: Starting receiver
mqueue_test: Set receiver priority to 128
receiver_thread: Starting
mqueue_test: Starting sender
mqueue_test: Set sender thread priority to 64
mqueue_test: Waiting for sender to complete
sender_thread: Starting
receiver_thread: mq_receive succeeded on msg 0
sender_thread: mq_send succeeded on msg 0
receiver_thread: mq_receive succeeded on msg 1
sender_thread: mq_send succeeded on msg 1
receiver_thread: mq_receive succeeded on msg 2
sender_thread: mq_send succeeded on msg 2
receiver_thread: mq_receive succeeded on msg 3
sender_thread: mq_send succeeded on msg 3
receiver_thread: mq_receive succeeded on msg 4
sender_thread: mq_send succeeded on msg 4
receiver_thread: mq_receive succeeded on msg 5
sender_thread: mq_send succeeded on msg 5
receiver_thread: mq_receive succeeded on msg 6
sender_thread: mq_send succeeded on msg 6
receiver_thread: mq_receive succeeded on msg 7
sender_thread: mq_send succeeded on msg 7
receiver_thread: mq_receive succeeded on msg 8
sender_thread: mq_send succeeded on msg 8
receiver_thread: mq_receive succeeded on msg 9
sender_thread: mq_send succeeded on msg 9
sender_thread: returning nerrors=0
mqueue_test: Killing receiver
receiver_thread: mq_receive interrupted!
receiver_thread: returning nerrors=0
mqueue_test: Canceling receiver
mqueue_test: receiver has already terminated

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         3        3
mxordblk  3e16570  3e04260
uordblks   1e8240   1fbbf0
fordblks  3e17dc0  3e04410

user_main: timed message queue test
timedmqueue_test: Starting sender
timedmqueue_test: Waiting for sender to complete
sender_thread: Starting
sender_thread: mq_timedsend succeeded on msg 0
sender_thread: mq_timedsend succeeded on msg 1
sender_thread: mq_timedsend succeeded on msg 2
sender_thread: mq_timedsend succeeded on msg 3
sender_thread: mq_timedsend succeeded on msg 4
sender_thread: mq_timedsend succeeded on msg 5
sender_thread: mq_timedsend succeeded on msg 6
sender_thread: mq_timedsend succeeded on msg 7
sender_thread: mq_timedsend succeeded on msg 8
sender_thread: mq_timedsend 9 timed out as expected
sender_thread: returning nerrors=0
timedmqueue_test: Starting receiver
timedmqueue_test: Waiting for receiver to complete
receiver_thread: Starting
receiver_thread: mq_timedreceive succeed on msg 0
receiver_thread: mq_timedreceive succeed on msg 1
receiver_thread: mq_timedreceive succeed on msg 2
receiver_thread: mq_timedreceive succeed on msg 3
receiver_thread: mq_timedreceive succeed on msg 4
receiver_thread: mq_timedreceive succeed on msg 5
receiver_thread: mq_timedreceive succeed on msg 6
receiver_thread: mq_timedreceive succeed on msg 7
receiver_thread: mq_timedreceive succeed on msg 8
receiver_thread: Receive 9 timed out as expected
receiver_thread: returning nerrors=0
timedmqueue_test: Test complete

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         3        3
mxordblk  3e04260  3e04220
uordblks   1fbbf0   1fbbf0
fordblks  3e04410  3e04410

user_main: sigprocmask test
sigprocmask_test: SUCCESS

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         3        3
mxordblk  3e04220  3e04220
uordblks   1fbbf0   1fbbf0
fordblks  3e04410  3e04410

user_main: signal handler test
sighand_test: Initializing semaphore to 0
sighand_test: Unmasking SIGCHLD
sighand_test: Registering SIGCHLD handler
sighand_test: Starting waiter task
sighand_test: Started waiter_main pid=78
waiter_main: Waiter started
waiter_main: Unmasking signal 32
waiter_main: Registering signal handler
waiter_main: oact.sigaction=0 oact.sa_flags=0 oact.sa_mask=0000000000000000
waiter_main: Waiting on semaphore
sighand_test: Signaling pid=78 with signo=32 sigvalue=42
waiter_main: sem_wait() successfully interrupted by signal
waiter_main: done
sighand_test: done

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         3        2
mxordblk  3e04220  3e16570
uordblks   1fbbf0   1e9a60
fordblks  3e04410  3e165a0

user_main: nested signal handler test
signest_test: Starting signal waiter task at priority 101
waiter_main: Waiter started
waiter_main: Setting signal mask
waiter_main: Registering signal handler
waiter_main: Waiting on semaphore
signest_test: Started waiter_main pid=79
signest_test: Starting interfering task at priority 102
interfere_main: Waiting on semaphore
signest_test: Started interfere_main pid=84
signest_test: Simple case:
  Total signalled 1240  Odd=620 Even=620
  Total handled   1240  Odd=620 Even=620
  Total nested    0    Odd=0   Even=0  
signest_test: With task locking
  Total signalled 2480  Odd=1240 Even=1240
  Total handled   2480  Odd=1240 Even=1240
  Total nested    0    Odd=0   Even=0  
signest_test: With intefering thread
  Total signalled 3720  Odd=1860 Even=1860
  Total handled   3720  Odd=1860 Even=1860
  Total nested    0    Odd=0   Even=0  
signest_test: done

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         2        4
mxordblk  3e16570  3e036b8
uordblks   1e9a60   1fbcd0
fordblks  3e165a0  3e04330

user_main: wdog test
wdog_test start...
wdtest_once 0 ns
wdtest_once 0 ns
wdtest_once 0 ns
wdtest_once 0 ns
wdtest_once 1 ns
wdtest_once 1 ns
wdtest_once 1 ns
wdtest_once 1 ns
wdtest_once 10 ns
wdtest_once 10 ns
wdtest_once 10 ns
wdtest_once 10 ns
wdtest_once 100 ns
wdtest_once 100 ns
wdtest_once 100 ns
wdtest_once 100 ns
wdtest_once 1000 ns
wdtest_once 1000 ns
wdtest_once 1000 ns
wdtest_once 1000 ns
wdtest_once 10000 ns
wdtest_once 10000 ns
wdtest_once 10000 ns
wdtest_once 10000 ns
wdtest_once 100000 ns
wdtest_once 100000 ns
wdtest_once 100000 ns
wdtest_once 100000 ns
wdtest_once 1000000 ns
wdtest_once 1000000 ns
wdtest_once 1000000 ns
wdtest_once 1000000 ns
wd_start with maximum delay, cancel OK, rest 1073741821
wdtest_recursive 1000000ns
wd_start with maximum delay, cancel OK, rest 1073741821
wdtest_recursive 1000000ns
wd_start with maximum delay, cancel OK, rest 1073741821
wdtest_recursive 1000000ns
wd_start with maximum delay, cancel OK, rest 1073741821
wdtest_recursive 1000000ns
recursive wdog triggered 6 times, elapsed tick 12
wdtest_recursive 10000000ns
recursive wdog triggered 6 times, elapsed tick 12
wdtest_recursive 10000000ns
recursive wdog triggered 6 times, elapsed tick 12
wdtest_recursive 10000000ns
recursive wdog triggered 6 times, elapsed tick 12
wdtest_recursive 10000000ns
recursive wdog triggered 6 times, elapsed tick 12
recursive wdog triggered 6 times, elapsed tick 12
recursive wdog triggered 6 times, elapsed tick 12
recursive wdog triggered 6 times, elapsed tick 12
wdog_test end...

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         4        6
mxordblk  3e036b8  3de26a8
uordblks   1fbcd0   209680
fordblks  3e04330  3df6980

user_main: POSIX timer test
timer_test: Initializing semaphore to 0
timer_test: Unmasking signal 32
timer_test: Registering signal handler
timer_test: oact.sigaction=0 oact.sa_flags=0 oact.sa_mask=0000000000000000
timer_test: Creating timer
timer_test: Starting timer
timer_test: Waiting on semaphore
timer_expiration: Received signal 32
timer_expiration: sival_int=42
timer_expiration: si_code=2 (SI_TIMER)
timer_expiration: ucontext=0
timer_test: sem_wait() successfully interrupted by signal
timer_test: g_nsigreceived=1
timer_test: Waiting on semaphore
timer_expiration: Received signal 32
timer_expiration: sival_int=42
timer_expiration: si_code=2 (SI_TIMER)
timer_expiration: ucontext=0
timer_test: sem_wait() successfully interrupted by signal
timer_test: g_nsigreceived=2
timer_test: Waiting on semaphore
timer_expiration: Received signal 32
timer_expiration: sival_int=42
timer_expiration: si_code=2 (SI_TIMER)
timer_expiration: ucontext=0
timer_test: sem_wait() successfully interrupted by signal
timer_test: g_nsigreceived=3
timer_test: Waiting on semaphore
timer_expiration: Received signal 32
timer_expiration: sival_int=42
timer_expiration: si_code=2 (SI_TIMER)
timer_expiration: ucontext=0
timer_test: sem_wait() successfully interrupted by signal
timer_test: g_nsigreceived=4
timer_test: Waiting on semaphore
timer_expiration: Received signal 32
timer_expiration: sival_int=42
timer_expiration: si_code=2 (SI_TIMER)
timer_expiration: ucontext=0
timer_test: sem_wait() successfully interrupted by signal
timer_test: g_nsigreceived=5
timer_test: Deleting timer
timer_test: done

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         6        6
mxordblk  3de26a8  3de26a8
uordblks   209680   209680
fordblks  3df6980  3df6980

user_main: barrier test
barrier_test: Initializing barrier
barrier_test: Thread 0 created
barrier_test: Thread 1 created
barrier_test: Thread 2 created
barrier_test: Thread 3 created
barrier_test: Thread 4 created
barrier_test: Thread 5 created
barrier_test: Thread 6 created
barrier_test: Thread 7 created
barrier_func: Thread 0 started
barrier_func: Thread 1 started
barrier_func: Thread 2 started
barrier_func: Thread 3 started
barrier_func: Thread 4 started
barrier_func: Thread 5 started
barrier_func: Thread 6 started
barrier_func: Thread 7 started
barrier_func: Thread 0 calling pthread_barrier_wait()
barrier_func: Thread 1 calling pthread_barrier_wait()
barrier_func: Thread 2 calling pthread_barrier_wait()
barrier_func: Thread 3 calling pthread_barrier_wait()
barrier_func: Thread 4 calling pthread_barrier_wait()
barrier_func: Thread 5 calling pthread_barrier_wait()
barrier_func: Thread 6 calling pthread_barrier_wait()
barrier_func: Thread 7 calling pthread_barrier_wait()
barrier_func: Thread 7, back with status=PTHREAD_BARRIER_SERIAL_THREAD (I AM SPECIAL)
barrier_func: Thread 0, back with status=0 (I am not special)
barrier_func: Thread 1, back with status=0 (I am not special)
barrier_func: Thread 2, back with status=0 (I am not special)
barrier_func: Thread 3, back with status=0 (I am not special)
barrier_func: Thread 4, back with status=0 (I am not special)
barrier_func: Thread 5, back with status=0 (I am not special)
barrier_func: Thread 6, back with status=0 (I am not special)
barrier_func: Thread 7 done
barrier_func: Thread 0 done
barrier_func: Thread 1 done
barrier_func: Thread 2 done
barrier_func: Thread 3 done
barrier_func: Thread 4 done
barrier_func: Thread 5 done
barrier_func: Thread 6 done
barrier_test: Thread 0 completed with result=0
barrier_test: Thread 1 completed with result=0
barrier_test: Thread 2 completed with result=0
barrier_test: Thread 3 completed with result=0
barrier_test: Thread 4 completed with result=0
barrier_test: Thread 5 completed with result=0
barrier_test: Thread 6 completed with result=0
barrier_test: Thread 7 completed with result=0

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         6        5
mxordblk  3de26a8  3da0688
uordblks   209680   25c6f0
fordblks  3df6980  3da3910

user_main: setjmp test
setjmp_test: Initializing jmp_buf
setjmp_test: Try jump
setjmp_test: About to jump, longjmp with ret val: 123
setjmp_test: Jump succeed
setjmp_test: Try jump
setjmp_test: About to jump, longjmp with ret val: 0
setjmp_test: Jump succeed

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         5        5
mxordblk  3da0688  3da0688
uordblks   25c6f0   25c6f0
fordblks  3da3910  3da3910

user_main: scheduler lock test
sched_lock: Starting lowpri_thread at 97
sched_lock: Set lowpri_thread priority to 97
sched_lock: Starting highpri_thread at 98
sched_lock: Set highpri_thread priority to 98
sched_lock: Waiting...
sched_lock: PASSED No pre-emption occurred while scheduler was locked.
sched_lock: Starting lowpri_thread at 97
sched_lock: Set lowpri_thread priority to 97
sched_lock: Starting highpri_thread at 98
sched_lock: Set highpri_thread priority to 98
sched_lock: Waiting...
sched_lock: PASSED No pre-emption occurred while scheduler was locked.
sched_lock: Finished

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         5        5
mxordblk  3da0688  3e036b8
uordblks   25c6f0   1f8cd0
fordblks  3da3910  3e07330

user_main: nxevent test

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         5        6
mxordblk  3e036b8  3df2eb0
uordblks   1f8cd0   1f8cd0
fordblks  3e07330  3e07330

Final memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     4000000  4000000
ordblks         1        6
mxordblk  3e289b0  3df2eb0
uordblks   1d7650   1f8cd0
fordblks  3e289b0  3e07330
user_main: Exiting
ostest_main: Exiting with status 0
stdio_test: Standard I/O Check: fprintf to stderr
nsh> free
      total       used       free    maxused    maxfree  nused  nfree name
   67108864    1788280   65320584    2476672   65103216     70      3 Umem
nsh> poweroff

archer@archer:~/code/nuttx/n8/nuttx$ git diff 
diff --git a/boards/sim/sim/sim/configs/nsh/defconfig b/boards/sim/sim/sim/configs/nsh/defconfig
index 8517209444..77350c394d 100644
--- a/boards/sim/sim/sim/configs/nsh/defconfig
+++ b/boards/sim/sim/sim/configs/nsh/defconfig
@@ -16,6 +16,7 @@ CONFIG_BOARDCTL_POWEROFF=y
 CONFIG_BOARD_LOOPSPERMSEC=0
 CONFIG_BOOT_RUNFROMEXTSRAM=y
 CONFIG_BUILTIN=y
+CONFIG_CANCELLATION_POINTS=y
 CONFIG_COVERAGE_ALL=y
 CONFIG_COVERAGE_TOOLCHAIN=y
 CONFIG_DEBUG_ASSERTIONS=y

anchao and others added 5 commits December 21, 2025 20:03
@anchao
Reapply "sched/group: move task group into task_tcb_s to improve perf…
c155ed2 
…ormance"

This reverts commit 31e562b.

Signed-off-by: chao an <anchao.archer@bytedance.com>
@anjiahao1 @anchao
sched:use tcb_s inside of task_tcb_s , remove all cast
36747c4 
Simplify the code and remove different tcb

Signed-off-by: anjiahao <anjiahao@xiaomi.com>
@anjiahao1 @anchao
arch:remove struct tcb_s cast
387650c 
Just remove cast

Signed-off-by: anjiahao <anjiahao@xiaomi.com>
@anjiahao1 @anchao
pynuttx:remove pthread_tcb_s cast
5e814eb 
Just remove cast

Signed-off-by: anjiahao <anjiahao@xiaomi.com>
@anchao
sched/task: Relocate the group ahead of the tcb to ensure the group d…
2a0345e 
…rop logic

Relocate the group ahead of the tcb to ensure that the relationship between
the group and tcb remains bound throughout the task lifecycle.
This eliminates the need to add excessive redundant checks to prevent erroneous release of the group.

Signed-off-by: chao an <anchao.archer@bytedance.com>
@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Area: Tooling Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: ceva Issues related to CEVA architecture Arch: mips Issues related to the MIPS architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: simulator Issues related to the SIMulator Arch: x86_64 Issues related to the x86_64 architecture Area: Memory Management Memory Management issues Area: OS Components OS Components issues Area: BINFMT Size: L The size of the change in this PR is large labels Dec 21, 2025
@anchao anchao mentioned this pull request Dec 21, 2025
Merged
@acassis
Copy link
Contributor

acassis commented Dec 21, 2025

@anchao nice work! What test did you added to validate it? Should be it included in the ostest to catch this kind of regression in the future?

@anchao
Copy link
Contributor Author

anchao commented Dec 21, 2025

@anchao nice work! What test did you added to validate it? Should be it included in the ostest to catch this kind of regression in the future?

@acassis Thank you for your review. Seriously , the probability of reproducing this issue is extremely low, as it requires kernel hacking to meet the test conditions. You may refer to commit #17418 (comment) in comment master...wangzhi16:nuttx:master.

I haven’t figured out a good test scheme yet.

@acassis
Copy link
Contributor

acassis commented Dec 21, 2025

@anchao nice work! What test did you added to validate it? Should be it included in the ostest to catch this kind of regression in the future?

@acassis Thank you for your review. Seriously , the probability of reproducing this issue is extremely low, as it requires kernel hacking to meet the test conditions. You may refer to commit #17418 (comment) in comment master...wangzhi16:nuttx:master.

I haven’t figured out a good test scheme yet.

Hi @anchao fair enough! No problem. If you find some yet to test the issue, please include it in the ostest.

@GUIDINGLI
Copy link
Contributor

GUIDINGLI commented Dec 22, 2025

Hi anchao,

Let's wait this PR merged:
#17545

GUIDINGLI
GUIDINGLI requested changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@GUIDINGLI GUIDINGLI left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want revert back your less-malloc patch, should in a independ PR

@anchao
Copy link
Contributor Author

anchao commented Dec 22, 2025

If you want revert back your less-malloc patch, should in a independ PR

I will rebase this change if #17545 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GUIDINGLI GUIDINGLI GUIDINGLI requested changes

@xiaoxiang781216 xiaoxiang781216 Awaiting requested review from xiaoxiang781216 xiaoxiang781216 is a code owner

@pussuw pussuw Awaiting requested review from pussuw pussuw is a code owner

@davids5 davids5 Awaiting requested review from davids5 davids5 is a code owner

@Donny9 Donny9 Awaiting requested review from Donny9 Donny9 is a code owner

@masayuki2009 masayuki2009 Awaiting requested review from masayuki2009 masayuki2009 is a code owner

@jerpelea jerpelea Awaiting requested review from jerpelea jerpelea is a code owner

@yf13 yf13 Awaiting requested review from yf13 yf13 is a code owner

@gustavonihei gustavonihei Awaiting requested review from gustavonihei gustavonihei is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: ceva Issues related to CEVA architecture Arch: mips Issues related to the MIPS architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: simulator Issues related to the SIMulator Arch: x86_64 Issues related to the x86_64 architecture Area: BINFMT Area: Documentation Improvements or additions to documentation Area: Memory Management Memory Management issues Area: OS Components OS Components issues Area: Tooling Size: L The size of the change in this PR is large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anchao @acassis @GUIDINGLI @anjiahao1