-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-14211. Extract base RDBBatchOperation, rename implementation to AtomicRDBBatchOperation #9526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ntroduce base abstract class RDBBatchOperation Change-Id: Ia81bd22e402fb8e96a613760bce9fd97ac51d849
|
@adoroszlai I renamed the class here the diff ideally should only do rename RDBBatchOperation -> AtomicRDBBatchOperation and then create a new RDBBatchOperation class |
|
This PR should not introduce the new base class, nor touch
( |
|
Created #9545 for the factory method. After that, this PR can focus on renaming |
| */ | ||
| public final class RDBBatchOperation implements BatchOperation { | ||
| static final Logger LOG = LoggerFactory.getLogger(RDBBatchOperation.class); | ||
| public abstract class RDBBatchOperation implements BatchOperation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can RDBBatchOperation be an interface instead of abstract class? (It was one in #9511.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be only abstact classes since interfaces don't allow package private methods. The methods should not be exposed outside the db package
What changes were proposed in this pull request?
Rename RDBBatchOperation as AtomicRDBBatchOperation and introduce base abstract class RDBBatchOperation
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14211
How was this patch tested?
Just refactoring no additional tests required