HDDS-14233. Reduce duplication in S3 object tagging tests #9548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
added
test
s3
Contributor
|
@adoroszlai thanks for the patch ! LGTM |
ivandika3
approved these changes
Dec 27, 2025
Contributor
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
Thanks for the cleanup. LGTM +1.
Contributor
Author
|
Thanks @ivandika3, @rich7420 for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Create and use helpers for put/get/delete object tagging in S3 unit tests. Clean up test classes being touched.
https://issues.apache.org/jira/browse/HDDS-14233
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/20468209800