HDDS-7523. ContainerReportQueue#take may return null #9581
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargi-jais11
reviewed
Jan 5, 2026
Contributor
Gargi-jais11
left a comment
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @cchung100m for the patch.
It seems that all other three bugs reported in the main jira is already fixed and even in the sonarcloud its not there.
LGTM.
Gargi-jais11
approved these changes
Jan 5, 2026
Contributor
|
@cchung100m Please fix the PR title to |
adoroszlai
changed the title
Contributor
|
Thanks @cchung100m for the patch. Since this is such a small change, can you please also fix some other warnings in the same file?
|
adoroszlai
reviewed
Jan 7, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @cchung100m for updating the patch.
| Objects.requireNonNull(value); | ||
| while (!addValue(value)) { | ||
| Thread.currentThread().sleep(10); | ||
| Thread.sleep(10); |
Contributor
There was a problem hiding this comment.
There is one more:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the take function is marked
@Nonnullbut but null might returnedWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7523
How was this patch tested?
Existing unit and integration tests