Make automatic flushing of compression configurable #2467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
make-auto-flush-configurable
branch
from
b6e021c to
ad610cf
Compare
mdedetrich
requested review from
He-Pin,
Roiocam,
danischroeter,
gmethvin,
jrudolph,
nvollmar,
pjfanning,
ptrdom,
raboof,
samueleresca and
seglo
mdedetrich
commented
Nov 9, 2025
| } | ||
|
|
||
| "be able to decode chunk-by-chunk (depending on input chunks)" in { | ||
| assume(autoFlush) |
Contributor
Author
There was a problem hiding this comment.
This test is only valid when you flush on each element on the stream as its testing that each individual element can be decompressed on its own and that is not the case when you have autoFlush disabled
He-Pin
reviewed
Nov 10, 2025
| case object AllDataAllowed extends Exception with NoStackTrace | ||
| protected def corruptInputCheck: Boolean = true | ||
|
|
||
| protected def autoFlush: Boolean = true |
Member
There was a problem hiding this comment.
does that need flush interval too?
Contributor
Author
There was a problem hiding this comment.
Nope, having an interval based flush with compression would yield wild results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One interesting facet when working on the compression code is that while the
compressmethod inCompressionUtilsis used in tests, its actually never actually used in production for any of the pekko-stream compresion methods. OnlycompressAndFlushis used in production, hence this PR makes the flush behaviour of pekko-stream compression configurable, solving akka/akka-core#21849.Tests have been added to make sure that this behaviour works as expected. Also this PR is required for #2409 as I also want the flush behaviour to be configurable in that PR too and so I need to reuse the newly added
autoFlushparameter onCompressionUtils. Docs have also been modified to reflect the changes.The PR can be safely backported to 1.3.0 branch hence the
@since 1.3.0.