chore: Remove CollectionUtil (#2582) #2584
Closed
+56
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit f735cca) # Conflicts: # stream/src/main/scala-2.13/org/apache/pekko/stream/javadsl/CollectionUtil.scala # stream/src/main/scala/org/apache/pekko/stream/javadsl/Flow.scala # stream/src/main/scala/org/apache/pekko/stream/javadsl/Sink.scala # stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala # stream/src/main/scala/org/apache/pekko/stream/javadsl/SubFlow.scala # stream/src/main/scala/org/apache/pekko/stream/javadsl/SubSource.scala # stream/src/main/scala/org/apache/pekko/stream/javadsl/Tcp.scala
Member
Author
|
@pjfanning This is ready for 1.5.x |
Member
|
I can half understand backporting #2583 but I don't see any benefit to backporting this. |
Member
|
In particular, I would be worried that some pekko module uses CollectionUtil. We have broken releases before by removing classes. If I get outvoted on this, the one thing that is a blocker for me is removing the class. We could backport the code changes without deleting the class. But my preference is not to bother. 2.0.0 will be finished faster if we don't waste so much time on 1.x. |
Member
Author
|
OK isee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit f735cca)