Skip to content

[fix] Remove the pulsar-bom import #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StevenLuMT wants to merge 1 commit into from
Closed

[fix] Remove the pulsar-bom import #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<maven.compiler.release>17</maven.compiler.release>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<pulsar.version>4.0.5</pulsar.version>
<default.pulsar.version>4.0.5</default.pulsar.version>
<maven-checkstyle-plugin.version>3.4.0</maven-checkstyle-plugin.version>
<puppycrawl.checkstyle.version>8.45.1</puppycrawl.checkstyle.version>
<spotless-maven-plugin.version>2.43.0</spotless-maven-plugin.version>
Expand All @@ -73,13 +73,6 @@
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
Copy link
Contributor

@AuroraTwinkle AuroraTwinkle Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this BOM? Did you encounter any problems?

<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-bom</artifactId>
<version>${pulsar.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-pool2</artifactId>
Expand Down
7 changes: 2 additions & 5 deletions pulsar-admin-mcp-contrib/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,12 @@
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client</artifactId>
<version>${default.pulsar.version}</version>
</dependency>
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client-admin</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client-admin</artifactId>
<version>${default.pulsar.version}</version>
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pulsar-client-admin dependency is missing the <scope>test</scope> that was present in the removed duplicate declaration. If this dependency is only needed for tests, the test scope should be retained on line 42.

Suggested change
<version>${default.pulsar.version}</version>
<version>${default.pulsar.version}</version>
<scope>test</scope>

Copilot uses AI. Check for mistakes.
</dependency>
<dependency>
<groupId>org.eclipse.jetty</groupId>
Expand Down
1 change: 1 addition & 0 deletions pulsar-client-common-contrib/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client-all</artifactId>
<version>${default.pulsar.version}</version>
</dependency>
</dependencies>
<inceptionYear>2024</inceptionYear>
Expand Down
2 changes: 2 additions & 0 deletions pulsar-rpc-contrib/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,12 @@
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client</artifactId>
<version>${default.pulsar.version}</version>
</dependency>
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client-admin</artifactId>
<version>${default.pulsar.version}</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion pulsar-rpc-contrib/src/main/resources/pulsar-container.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
# limitations under the License.
#

pulsar.version=${pulsar.version}
pulsar.version=${default.pulsar.version}
2 changes: 1 addition & 1 deletion pulsar-transaction-contrib/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client-all</artifactId>
<version>${pulsar.version}</version>
<version>${default.pulsar.version}</version>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
Expand Down