[SYSTEMDS-3891] Improved Stream Handling and PCA support #2368
+1,062
−271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces various bugfixes and improvements to stream handling to address synchronization issues leading to deadlocks in specific cases (we now reliably guarantee that the finalizer callback is invoked after the last consumer finished execution). Further, the
Teeinstruction was modified to be introduced by statement level rewrites to keep track of transient reads / writes which led to issues with the previous DAG rewrite.Finally, we introduced basic block tracking to remove items from the
OOCEvictionManageronce they have no pending consumers. To achieve that, we track stream references and once no variable holds the underlyingCachingStreamwe mark it as deletable (because then we know, that no additional stream consumer will be added). Blocks from deletable streams can safely be removed from the cache once their consumption count reaches the final number of registered consumers.Note that we modified the
VariableCPInstructionto access variable remove and copy events.