Fix crash by replacing deprecated logger.warn with logger.warning #20
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an
AttributeError: 'Logger' object has no attribute 'warn'that occurs during inference.In Python 3.13, the
warn()method has been removed, leading to a crash. Replacing it withwarning(), the standard recommended method, resolves this issue and ensures the tool remains usable in modern environments.Changes
src/sharp/utils/io.py: ChangedLOGGER.warn()toLOGGER.warning().grep -r --include="*.py" "\.warn(" .that no other occurrences of.warn()exist within thesrcdirectory.Impact
This is a non-breaking change that prevents the application from crashing when EXIF data (focal length) is missing from input images.
Testing
.warning().By submitting this pull request, I represent that I have the right to license my contribution to Apple and the community, and agree that my contributions are licensed under the LICENSE of this repository.