-
Notifications
You must be signed in to change notification settings - Fork 669
Vconsole.conf KEYMAP= FONT= _base mkinitcpio.conf v40 error #3928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e1838a5
pr1
h8d13 3da5c8c
pr2
h8d13 35a7d6e
pr2-2
h8d13 9933b88
pr2-3
h8d13 3f8b4dc
Revert genfstab and pacstrap command changes
h8d13 1952de9
mistake
h8d13 3508256
Merge branch 'archlinux:master' into vconsole
h8d13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it certain that this file does not exist at this point? If so then this iwll override any existing content
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, shouldn't we use
localectlto update the file?Running a
localectrl set-keymap XXXwill update this file for me, so I don't understand why we would want to do this manually?We may have to update the call here https://github.com/svartkanin/archinstall/blob/275259928c34d59cd166055e675938719b2b7276/archinstall/lib/installer.py?plain=1#L1779 to also call
localectlon targetUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically without it the first base hook fails hence why i needed to place it before
_baseAnd calling localectl before base well this was more straightforward and uses already existing content of config.
https://www.reddit.com/r/archlinux/comments/1otgoas/issue_with_mkinitcpio/
This also makes encryption layouts possible i guess ? I was using
ckbcompwith grub manually before to generate layout files for French keyboard from AUR 😩These need to be latin compatible to my understanding at least with grub which why I had added all the docs comments lmao but since you validate ASCII for passwords and such
And i think these are different things needs specifically
KEYMAP=andFONT=Maybe we could detect screen size to set font to larger alternative dynamically
Sorry for bad img from reddit
Currently same happens with archinstall but keeps going (non-fatal) with
vconsole.confbeing set:Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also since it's called before it doesn't get overwritten in the subsequent calls
Continuation of #1187 with a earlier approach @svartkanin would be great to get some feedback as this could help many users using different kb than US (altho I'm unsure about limitation outside of latin range). Or update instructions: https://github.com/archlinux/archinstall/blob/master/archinstall/locales/README.md
You test on branch:
testingin https://github.com/h8d13/archinstall-patchWhich also includes my hardware draft for laptops