-
Notifications
You must be signed in to change notification settings - Fork 7
[Bug] remove compatible models from brick instance list endpoint #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] remove compatible models from brick instance list endpoint #115
Conversation
8ae6e81 to
dccfa09
Compare
dido18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have tests for the endpoint or bricks ?
I see no modification in *_test.go files
We already have both unit and e2e tests for TestBricksDetails, added in the previous issues handled by Giulio and me. |
| Author: "Arduino", // TODO: for now we only support our bricks | ||
| Category: brick.Category, | ||
| Status: "installed", | ||
| RequireModel: brick.RequireModel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the require_model must be kept in the response, isn't it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I preferred to restart the PR here: #120
Ensuring to have an up-to-date repo and integrating unit and e2e tests.
|
moved #120 |
Motivation
closes #114
The v1/apps/{id}/bricks response must not include
compatible_models fields.Change description
Decouple the
v1/apps/{id}/bricksandv1/apps/{id}/bricks/{brick_id}response structures by creating a dedicated struct for thev1/apps/{id}/bricksendpoint.Additional Notes
Reviewer checklist
main.