Skip to content

#37 Fix invalid tag name #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThisIsJustARandomGuy wants to merge 2 commits into
base: master-3.x
Choose a base branch
from
Open

#37 Fix invalid tag name #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbd0134
#37 Fix invalid tag name
Jan 27, 2025
b8b5979
Add jQuery file
Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/QuickTranslateBundle/Controller/ObjectController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function translateObjectAction(Request $request)
$item = DataObject::getById($itemId);

foreach ($data as $key => $value) {
if (str_contains($key, 'structuredData#')) {
if (str_contains($key, 'structuredData---')) {
list($prefix, $fieldName, $index, $type, $strField) = explode('.', $key);

$structuredField = $item->get($fieldName);
Expand All @@ -50,7 +50,7 @@ public function translateObjectAction(Request $request)
$localizedFields->setLocalizedValue($strField, $value, $localizedField);
}

} elseif (str_contains($key, 'classificationStore#')) {
} elseif (str_contains($key, 'classificationStore---')) {
list($prefix, $index, $fieldName, $strField) = explode('.', $key);

$structuredField = $item->get($fieldName);
Expand Down
2 changes: 2 additions & 0 deletions src/QuickTranslateBundle/Resources/public/js/pimcore/jquery-3.6.0.min.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions src/QuickTranslateBundle/Resources/public/js/quick-translate-btn/quickTranslateObjectBtn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ pimcore.element.quickTranslateObjectBtn = Class.create({
if (elementData[item].length && element.data.localizedfields.data[langs[0]]) {
let localizedFields = element.data.localizedfields.data[langs[0]];
for (let field in localizedFields) {
localizedFields[`structuredData#.${item}.${index}.${element.type}.${field}`] = localizedFields[field];
localizedFields[`structuredData---.${item}.${index}.${element.type}.${field}`] = localizedFields[field];
delete localizedFields[field];
}
data = {...data, ...localizedFields}
Expand All @@ -101,7 +101,7 @@ pimcore.element.quickTranslateObjectBtn = Class.create({
let localizedFields = elementData[item].data[langs[0]];
for (let storeObject in localizedFields) {
for (let field in localizedFields[storeObject]) {
localizedFields[storeObject][`classificationStore#.${storeObject}.${item}.${field}`] = localizedFields[storeObject][field];
localizedFields[storeObject][`classificationStore---.${storeObject}.${item}.${field}`] = localizedFields[storeObject][field];
delete localizedFields[storeObject][field];
}
data = { ...data, ...localizedFields[storeObject] }
Expand Down Expand Up @@ -365,4 +365,4 @@ pimcore.element.quickTranslateObjectBtn = Class.create({
},


});
});