Skip to content

Conversation

@troyfactor4
Copy link

@troyfactor4 troyfactor4 commented Mar 3, 2021

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Allow the user of the library to specify a signing or encryption strategy externally. Useful when signing keys are in remote servers or HSM devices and signing must happen async or with the use of custom APIs.

Testing

  • [ x ] This change adds test coverage for new/changed/fixed functionality

Checklist

  • [ x ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • [ x ] All active GitHub checks for tests, formatting, and security are passing
  • [ x ] The correct base branch is being used, if not master

@troyfactor4
Copy link
Author

Obsoletes #64
Closes issue #63

@troyfactor4
Copy link
Author

bump - any feedback here on potential changes? Hoping I followed the correct process for MR. I feel like async signing over PKCS11 could really improve the security posture of some organisations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant