Assignment two #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aditya-k-23
suggested changes
Dec 11, 2025
Aditya-k-23
left a comment
Aditya-k-23
left a comment
There was a problem hiding this comment.
Good job on the assignment. A small change is required in the return value of detect problems.
Please fix and resubmit for completion.
Thanks!
Owner
Author
|
Hello Aditya,
Thanks for notifying me about the change. I think I have now provided a
value that detect problem would require to return. Please see the pull
request below:
UofT-DSI#316
I hope I didn't mess up this time.
Regards
Sultan
From: Aditya Kulkarni ***@***.***>
Sent: Wednesday, December 10, 2025 7:09 PM
To: awanjp-dsi/python ***@***.***>
Cc: awanjp-dsi ***@***.***>; Author ***@***.***>
Subject: Re: [awanjp-dsi/python] Assignment two (PR #2)
@Aditya-k-23 requested changes on this pull request.
Good job on the assignment. A small change is required in the return value
of detect problems.
image.png (view on web)
<https://github.com/user-attachments/assets/f9673241-b62d-4899-b5e8-41a37c5b
48d8>
Please fix and resubmit for completion.
Thanks!
-
Reply to this email directly, view it on GitHub
<#2 (review)> ,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BY37KUHOP3QGQMT3UNEDIO34B
CYYDAVCNFSM6AAAAACOSIDOEKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTK
NRVGAYTQNRZGY> .
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Aditya-k-23
approved these changes
Dec 17, 2025
Aditya-k-23
left a comment
Aditya-k-23
left a comment
There was a problem hiding this comment.
Thank you for your submission, your assignment is complete!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist