-
Notifications
You must be signed in to change notification settings - Fork 46
perf: improve audit #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wlawt
wants to merge
9
commits into
master
Choose a base branch
from
archive-event-perf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
perf: improve audit #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlawt
commented
Jan 5, 2026
7bb290c to
d852680
Compare
wlawt
commented
Jan 5, 2026
d852680 to
67204a6
Compare
cody-wang-cb
reviewed
Jan 6, 2026
Contributor
cody-wang-cb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observations
archive_eventwe performedupdate_bundle_historyandupdate_tx_by_hashsequentially and blocked on each operation resulting in the duration being upwards of 600ms.Changes
Create a fixed number of workers (80) and do the updating in parallel
update_bundle_historyworst case took ~500ms and same forupdate_tx_by_hash. we can do this updating in parallelA fixed worker pool avoids resource exhaustion and provides backpressure via a bounded channel
Results
archive_event_durationwas 3.02ms, previous was 5.27ms.TODO:
test_userop_kafka_publisher_reader_integrationtest failing (nvm docker wasnt running)