-
Notifications
You must be signed in to change notification settings - Fork 34
Fixing #26 - broken unit tests #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
travis is failing because of invalid (?) composer configuration. I did not change anything within composer.json, so it has to be in there before my pull request... Any ideas? |
|
not sure, but we recently added a development branch. could you and change the target branch to develop? |
|
ok changed target branch to |
|
apparently not without a push. it's redoing the same branch... |
|
Ok will push again, I cant create another pull request to the same branch... |
|
master and develop should be equal at the moment that's more like composer problem. also, @koseduhemak when you create PR create it not from master because we can't edit or fix problems on your master branch instead create feature or hotfix branch and create PR from it |
|
ok then we can maybe close this pr and I open a new one with source branch |
|
closing here. See #99 |
Fixing #26 - broken unit tests.