Skip to content

Conversation

@koseduhemak
Copy link
Contributor

Fixing #26 - broken unit tests.

@coveralls
Copy link

coveralls commented Dec 5, 2017

Coverage Status

Coverage increased (+0.09%) to 82.461% when pulling 2dcd821 on koseduhemak:master into 2a8a0a6 on basz:master.

@koseduhemak
Copy link
Contributor Author

travis is failing because of invalid (?) composer configuration. I did not change anything within composer.json, so it has to be in there before my pull request... Any ideas?

@basz
Copy link
Owner

basz commented Dec 6, 2017

not sure, but we recently added a development branch. could you and change the target branch to develop?

@koseduhemak koseduhemak changed the base branch from master to develop December 6, 2017 11:13
@koseduhemak
Copy link
Contributor Author

ok changed target branch to develop. Is it possible to rerun travis?

@basz
Copy link
Owner

basz commented Dec 6, 2017

apparently not without a push. it's redoing the same branch...

@koseduhemak
Copy link
Contributor Author

koseduhemak commented Dec 6, 2017

Ok will push again, I cant create another pull request to the same branch...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 82.461% when pulling e833406 on koseduhemak:master into 2a8a0a6 on basz:develop.

@svycka
Copy link
Collaborator

svycka commented Dec 6, 2017

master and develop should be equal at the moment that's more like composer problem.

also, @koseduhemak when you create PR create it not from master because we can't edit or fix problems on your master branch instead create feature or hotfix branch and create PR from it

@koseduhemak
Copy link
Contributor Author

ok then we can maybe close this pr and I open a new one with source branch feature-phpunit to target branch develop.

@koseduhemak
Copy link
Contributor Author

closing here. See #99

@koseduhemak koseduhemak closed this Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants