-
Notifications
You must be signed in to change notification settings - Fork 7
Update pre-commit config file #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0857eac
ad5c639
c71ac3e
62ef47f
03af50f
d62d6c4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| // For format details, see https://aka.ms/devcontainer.json. For config options, see the | ||
| // README at: https://github.com/devcontainers/templates/tree/main/src/cpp | ||
| // README at: https://github.com/devcontainers/templates/tree/main/src/cpp | ||
JeffGarland marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| { | ||
| "name": "Beman Project Generic Devcontainer", | ||
| "image": "ghcr.io/bemanproject/infra-containers-devcontainer-gcc:14", | ||
| "postCreateCommand": "pre-commit", | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "ms-vscode.cpptools", | ||
| "ms-vscode.cmake-tools" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| { | ||
| "name": "Beman Project Generic Devcontainer", | ||
| "image": "ghcr.io/bemanproject/infra-containers-devcontainer-gcc:14", | ||
| "postCreateCommand": "pre-commit", | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "ms-vscode.cpptools", | ||
| "ms-vscode.cmake-tools" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| .cache | ||
| /compile_commands.json | ||
| /build | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| cmake_minimum_required(VERSION 3.28...4.1) | ||
| cmake_minimum_required(VERSION 3.28...4.2) | ||
|
|
||
| project( | ||
| beman.scope | ||
|
|
@@ -91,6 +91,8 @@ install( | |
|
|
||
| FILE_SET CXX_MODULES | ||
| DESTINATION ${CMAKE_INSTALL_INCLUDEDIR} | ||
| CXX_MODULES_BMI | ||
| DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/beman.scope/bmi-${CMAKE_CXX_COMPILER_ID}_$<CONFIG> | ||
|
Comment on lines
+94
to
+95
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note this!
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Noted. We don't have a standard for how to do this, but this seems reasonable for now -- but something we need to ultimately add into exemplar.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm going to merge this -- I've recorded an issue for us to look at bemanproject/exemplar#272 (comment) |
||
| FILE_SET HEADERS | ||
| ) | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.