Add service publicy to ensure compat with new Symfony 3.4 DI #72
Conversation
|
Hum I only changes services definitions from the main stream... I suppose that style errors are coming from different commits |
|
Hi @nmacherey, thanks for the PR! Can you please revert the style changes so we keep only the necessary changes.Thanks! |
|
Done ! I also made public the queue factory... #71 as We really need to create queue and call the consumer service manually in out behat tests. Using the CommandRunner is also an option but I would rather use the service layer. |
|
|
||
| <services> | ||
| <service id="bernard.data_collector.message" class="Bernard\BernardBundle\Collector\ProducerCollector"> | ||
| <service id="bernard.data_collector.message" class="Bernard\BernardBundle\Collector\ProducerCollector" public="true"> |
There was a problem hiding this comment.
Why does this service need to be public?
There was a problem hiding this comment.
In fact I don't know... I just took all services that where public using 3.3 and add the public tag...
| <container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
| <services> | ||
| <service id="bernard.command.consume" class="Bernard\Command\ConsumeCommand"> | ||
| <service id="bernard.command.consume" class="Bernard\Command\ConsumeCommand" public="true"> |
There was a problem hiding this comment.
Why do the commands need to be public?
2 participants
No description provided.