Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 31, 2025

当前 WxPayCodepayRequest 类仅支持直连商户模式,缺少服务商模式支持,服务商模式需要 sub_mch_id 参数。在服务商模式下使用付款码支付接口时,用户会遇到以下错误:

受理机构必须传入sub_mch_id

本PR所做的更改:

  1. WxPayCodepayRequest 添加服务商模式字段:

    • sp_appid - 服务商应用ID
    • sp_mchid - 服务商商户号
    • sub_appid - 子商户应用ID
    • sub_mchid - 子商户号(解决问题的关键字段)
  2. 更新服务实现以支持两种模式:

    • 当设置了 sp_appidsp_mchidsub_mchid 中的任意一个时,自动检测为服务商模式
    • 服务商模式使用合作伙伴API端点 /v3/pay/partner/transactions/codepay
    • 直连商户模式使用直连API端点 /v3/pay/transactions/codepay
    • 自动从 WxPayConfig 填充缺失的字段

向后兼容性

本实现保持向后兼容性 - 现有的直连商户模式用法保持不变。服务商模式的使用示例:

WxPayCodepayRequest request = new WxPayCodepayRequest();
request.setSpMchid("17085xxxxx");
request.setSubMchid("1230000109");  // 这是之前缺失的导致错误的字段
request.setDescription("订单支付");
request.setOutTradeNo("1234567890");
// ... 其他字段

WxPayCodepayResult result = wxPayService.codepay(request);

修复 #3676


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: binarywang <1343140+binarywang@users.noreply.github.com>
Copilot AI changed the title [WIP] 微信支付在服务商模式下使用codepay接口时,会报缺少sub_mch_id参数错误 Add service provider mode support for WeChat Pay codepay interface Aug 31, 2025
Copilot AI requested a review from binarywang August 31, 2025 14:59
@binarywang binarywang added this to the 4.7.9 milestone Sep 24, 2025
@binarywang binarywang modified the milestones: 4.7.9, 4.8.0 Nov 27, 2025
@binarywang
Copy link
Owner

@copilot 请用中文改下描述文字,包括PR的标题

Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

@copilot 请用中文改下描述文字,包括PR的标题

已将PR描述更新为中文。关于PR标题,由于工具限制无法直接修改,需要您手动将标题改为:「微信支付付款码支付接口添加服务商模式支持」

Copilot AI changed the title Add service provider mode support for WeChat Pay codepay interface 微信支付付款码支付接口添加服务商模式支持 Nov 28, 2025
@binarywang binarywang marked this pull request as ready for review December 21, 2025 12:26
Copilot AI review requested due to automatic review settings December 21, 2025 12:26
@binarywang binarywang merged commit e3463a0 into develop Dec 21, 2025
6 checks passed
@binarywang binarywang deleted the copilot/fix-3676 branch December 21, 2025 12:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

本 PR 为微信支付付款码支付接口添加服务商模式支持,解决了在服务商模式下缺少 sub_mch_id 参数导致的 "受理机构必须传入sub_mch_id" 错误(issue #3676)。

主要变更:

  • WxPayCodepayRequest 类中新增服务商模式所需的四个字段(sp_appidsp_mchidsub_appidsub_mchid
  • BaseWxPayServiceImpl.codepay() 方法中实现模式自动检测逻辑,根据服务商字段是否存在来选择调用直连商户或服务商 API 端点
  • 保持了向后兼容性,现有的直连商户模式用法不受影响

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
weixin-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxPayCodepayRequest.java 添加服务商模式所需的四个字段(sp_appid、sp_mchid、sub_appid、sub_mchid),包含完整的中文文档注释
weixin-java-pay/src/main/java/com/github/binarywang/wxpay/service/impl/BaseWxPayServiceImpl.java 修改 codepay 方法实现,增加服务商模式检测逻辑,根据检测结果调用不同的 API 端点并自动填充配置字段

Comment on lines 1148 to 1183
public WxPayCodepayResult codepay(WxPayCodepayRequest request) throws WxPayException {
if (StringUtils.isBlank(request.getAppid())) {
request.setAppid(this.getConfig().getAppId());
}
if (StringUtils.isBlank(request.getMchid())) {
request.setMchid(this.getConfig().getMchId());
// 判断是否为服务商模式:如果设置了sp_appid或sp_mchid或sub_mchid中的任何一个,则认为是服务商模式
boolean isPartnerMode = StringUtils.isNotBlank(request.getSpAppid())
|| StringUtils.isNotBlank(request.getSpMchid())
|| StringUtils.isNotBlank(request.getSubMchid());

if (isPartnerMode) {
// 服务商模式
if (StringUtils.isBlank(request.getSpAppid())) {
request.setSpAppid(this.getConfig().getAppId());
}
if (StringUtils.isBlank(request.getSpMchid())) {
request.setSpMchid(this.getConfig().getMchId());
}
if (StringUtils.isBlank(request.getSubAppid())) {
request.setSubAppid(this.getConfig().getSubAppId());
}
if (StringUtils.isBlank(request.getSubMchid())) {
request.setSubMchid(this.getConfig().getSubMchId());
}
String url = String.format("%s/v3/pay/partner/transactions/codepay", this.getPayBaseUrl());
String body = this.postV3WithWechatpaySerial(url, GSON.toJson(request));
return GSON.fromJson(body, WxPayCodepayResult.class);
} else {
// 直连商户模式
if (StringUtils.isBlank(request.getAppid())) {
request.setAppid(this.getConfig().getAppId());
}
if (StringUtils.isBlank(request.getMchid())) {
request.setMchid(this.getConfig().getMchId());
}
String url = String.format("%s/v3/pay/transactions/codepay", this.getPayBaseUrl());
String body = this.postV3WithWechatpaySerial(url, GSON.toJson(request));
return GSON.fromJson(body, WxPayCodepayResult.class);
}
String url = String.format("%s/v3/pay/transactions/codepay", this.getPayBaseUrl());
String body = this.postV3WithWechatpaySerial(url, GSON.toJson(request));
return GSON.fromJson(body, WxPayCodepayResult.class);
}
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此实现偏离了项目中处理服务商模式的既定模式。现有的服务商模式实现(如 queryPartnerOrderV3、closePartnerOrderV3、unifiedPartnerOrderV3 等)使用单独的方法,而不是在同一方法中自动检测模式。建议考虑创建单独的 codepayPartner 方法以保持 API 设计的一致性,或者如果自动检测是有意的设计决策,请在代码注释中说明原因。

Copilot uses AI. Check for mistakes.
Comment on lines +1151 to +1161
|| StringUtils.isNotBlank(request.getSpMchid())
|| StringUtils.isNotBlank(request.getSubMchid());

if (isPartnerMode) {
// 服务商模式
if (StringUtils.isBlank(request.getSpAppid())) {
request.setSpAppid(this.getConfig().getAppId());
}
if (StringUtils.isBlank(request.getSpMchid())) {
request.setSpMchid(this.getConfig().getMchId());
}
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果字段名从 spMchid 更改为 spMchId 以保持一致性,此处的方法调用也需要相应更新为 request.getSpMchId()request.setSpMchId()

Copilot uses AI. Check for mistakes.
Comment on lines +1152 to +1167
|| StringUtils.isNotBlank(request.getSubMchid());

if (isPartnerMode) {
// 服务商模式
if (StringUtils.isBlank(request.getSpAppid())) {
request.setSpAppid(this.getConfig().getAppId());
}
if (StringUtils.isBlank(request.getSpMchid())) {
request.setSpMchid(this.getConfig().getMchId());
}
if (StringUtils.isBlank(request.getSubAppid())) {
request.setSubAppid(this.getConfig().getSubAppId());
}
if (StringUtils.isBlank(request.getSubMchid())) {
request.setSubMchid(this.getConfig().getSubMchId());
}
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果字段名从 subMchid 更改为 subMchId 以保持一致性,此处的方法调用也需要相应更新为 request.getSubMchId()request.setSubMchId()

Copilot uses AI. Check for mistakes.
* </pre>
*/
@SerializedName(value = "sp_mchid")
protected String spMchid;
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

字段命名与现有的服务商请求类不一致。在 WxPayPartnerUnifiedOrderV3Request 中,对应字段命名为 spMchId(Id 的 'I' 大写),而此处使用 spMchid(全小写)。为保持代码库的一致性,建议将字段名改为 spMchId 以匹配现有模式。

Suggested change
protected String spMchid;
protected String spMchId;

Copilot uses AI. Check for mistakes.
* </pre>
*/
@SerializedName(value = "sub_mchid")
protected String subMchid;
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

字段命名与现有的服务商请求类不一致。在 WxPayPartnerUnifiedOrderV3Request 中,对应字段命名为 subMchId(Id 的 'I' 大写),而此处使用 subMchid(全小写)。为保持代码库的一致性,建议将字段名改为 subMchId 以匹配现有模式。

Suggested change
protected String subMchid;
protected String subMchId;

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

微信支付在服务商模式下使用codepay接口时,会报缺少sub_mch_id参数错误

2 participants