Allow Admins to Remove Samples #352
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <div class="row"> | ||
| <div class="col-12 mt-4 text-end"> | ||
| {% if not sample.sample_remove_locked and not admin_mode %} | ||
| {% if not sample.sample_remove_locked %} |
Collaborator
There was a problem hiding this comment.
Wait, so before this, regular users could remove a sample from (their own) profile but admins could NOT remove a sample from a user's profile? Was there a reason for that?
Collaborator
Author
There was a problem hiding this comment.
The decision to previously block admins from removing samples was driven by a few factors, mostly a combination of organizational composition and a desire/plan to build out tiered administrative privileges (in contrast to the current model where someone is either a normal user or has full administrative privileges). Since then, the former has changed and the latter has been shelved indefinitely, meaning it makes sense to restore this function for the foreseeable future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request grants admins the ability to remove samples from a profile (source) until the sample has been scanned by the wet lab. Once it has been scanned, admins will continue to be prevented from removing a sample, matching the behavior of normal users.
Additionally, I updated the word "source" in the confirmation message to "profile" to match the post-overhaul terminology displayed in the UI.