Skip to content

Bug fixes #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quantiom wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

Bug fixes #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3599a7
Remove faulty invalid transaction check
quantiom Aug 4, 2022
eb1eb6c
Fix giftcard creation not being awaited
quantiom Aug 4, 2022
efdcde6
Fix currency not being converted correctly
quantiom Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions pages/api/validateStatus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,24 +54,19 @@ export default async function handler(
return;
}

// If transaction doesn't exist, expire it on CoinPayments (in case it's been cancelled)
const key = getTransactionRedisKey(txn_id);
if (!(await get(key))) {
res.status(400).json({ error: "Invalid transaction!" });
return;
}

// Generate giftcard if applicable
const cardObj =
status === "2" || status === "100"
? {
card: generateGiftcard(
(await convertCurrency(amount as any, "USD", currency)).toString()
card: await generateGiftcard(
(await convertCurrency(amount as any, currency, "USD")).toString()
),
}
: undefined;

// Update status
const key = getTransactionRedisKey(txn_id);

redisClient.set(
key,
JSON.stringify({
Expand Down