Fix Repo.advisory_xact_lock/1 to handle atom names #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasknoepfle
approved these changes
Jan 5, 2026
Member
andreasknoepfle
left a comment
andreasknoepfle
left a comment
There was a problem hiding this comment.
A test would also be really nice, but I realise this function is yet untested...
Collaborator
Author
Could do just for testing the API, but I've tried before to test locks in unit tests and it's not trivial with actual concurrency. We could assert on the presence of a |
Member
|
A test that the function does not crash would maybe be enough. Would have worked to cover the case for atoms. |
Collaborator
Author
|
@andreasknoepfle added some tests |
maltoe
force-pushed
the
fix/advisory-xact-lock-should-accept-atoms
branch
from
15d12c6 to
4ef46d5
Compare
Merged
The docs claim
> We decided that we wanted to have atom or string keys for better readability.
... yet when I try it with an atom, I get
```elixir
iex(3)> MyApp.Repo.advisory_xact_lock(:foo)
** (ArgumentError) errors were found at the given arguments:
* 1st argument: not an iodata term
(erts 15.2.3) :erlang.iolist_to_binary(:foo)
(crypto 5.5.3) crypto.erl:1039: :crypto.hash/2
(bitcrowd_ecto 1.0.0) lib/bitcrowd_ecto/repo.ex:258: BitcrowdEcto.Repo.advisory_xact_lock/2
iex:3: (file)
```
maltoe
force-pushed
the
fix/advisory-xact-lock-should-accept-atoms
branch
from
4ef46d5 to
20f39f8
Compare
andreasknoepfle
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs claim
... yet when I try it with an atom, I get