Make adjacency_matrix implement BidirectionalGraph concept #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjacency matrix is by nature bidirectional and one can see that the concept was mostly implemented before. That implementation missed the degree function(s). These functions are implemented in this commit and the traversal_category is updated to meet the concept requirements. Tests are also added, though they are a bit shallow in the sense that they seem to omit intensive algorithms.
This was referenced Dec 12, 2024
jeremy-murphy
requested changes
Feb 25, 2025
Contributor
|
I thought it would be expedient to just fix the comments myself since the changes were trivial. |
jeremy-murphy
approved these changes
Feb 28, 2025
Contributor
jeremy-murphy
left a comment
jeremy-murphy
left a comment
There was a problem hiding this comment.
Thanks for a pragmatic missing piece of the puzzle!
|
Nice one @Wavetrace! |
Contributor
Author
|
Thanks, Jonas! Thanks a lot, Jeremy, for fixing the comment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjacency matrix is by nature bidirectional and one can see that the concept was mostly implemented before. That implementation missed the degree function(s). These functions are implemented in this commit and the traversal_category is updated to meet the concept requirements.
Tests are also added, though they are a bit shallow in the sense that they seem to omit intensive algorithms.
This PR is a consequence of work on #397 -- that one contains a test commented out, that ends up running
neighbor_bfson an adjacency matrix.Fixes #404